Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes where R.id.navigation_view wasn't found #759

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Fix crashes where R.id.navigation_view wasn't found #759

merged 1 commit into from
Jul 3, 2017

Conversation

veyndan
Copy link
Collaborator

@veyndan veyndan commented Jul 3, 2017

Closes #758.

I had forgotten to migrate all of the old drawer layouts to NavigationView in #752. This resolves that and should stop crashes related to R.id.navigation_view not being found.

@veyndan veyndan requested a review from whym July 3, 2017 06:13
@whym
Copy link
Collaborator

whym commented Jul 3, 2017

Looks good and the issue is resolved for me.

@misaochan misaochan merged commit e7044c9 into commons-app:master Jul 3, 2017
@veyndan veyndan deleted the navigation-view-fix branch July 3, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery pick crash: "Required view 'navigation_view' (snip) was not found"
3 participants