issue 5847 make the icon always visible and adjust the count #5896
+88
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gly and add some logs
Not at all, we are all here to learn. :-) And this is not a high-priority issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5847 issue 5847 make the icon always visible and adjust the count
According to your suggestion, "If reproduction seems too difficult, why not just make the icon always visible and just adjust the count accordingly as and when new uploads are queued / completed," I have set the upload icon to always be visible, and I have also included some logs from when I was debugging.
This is not the final version of the PR; I just wanted to show you my current modifications. To be honest, I feel that my changes, which only involve setting the upload icon to always visible in one method, might meet your requirement but seem superficial and possibly not in line with coding standards. I am not very satisfied with this modification. However, due to limitations in my skills and time, I haven't found a better method yet.
If you think it useful, I can delete all the logs and submit again. I apologize for not being able to successfully reproduce and resolve this issue. Perhaps you might consider finding someone else. I'm sorry for wasting your time.