Fixes #2388 Replace Toasts with Snackbars

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -518,7 +518,7 @@ private void showNearbyCardPermissionRationale() {
     }
 
     private void displayYouWontSeeNearbyMessage() {
-        ViewUtil.showLongToast(getActivity(), getResources().getString(R.string.unable_to_display_nearest_place));
+        ViewUtil.showLongSnackbar(requireView(),getString(R.string.unable_to_display_nearest_place));
         store.putBoolean("doNotAskForLocationPermission", true);
     }
 

app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.java

@@ -10,14 +10,14 @@
 import android.widget.ImageView;
 import android.widget.ListView;
 import android.widget.TextView;
-import android.widget.Toast;
 import androidx.annotation.NonNull;
 import androidx.appcompat.app.AlertDialog;
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
 import fr.free.nrw.commons.explore.SearchActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
 import java.util.List;
 import javax.inject.Inject;
 
@@ -82,8 +82,7 @@ private void setDeleteRecentPositiveButton(@NonNull final Context context,
         recentSearchesDao.deleteAll();
         recent_searches_delete_button.setVisibility(View.GONE);
         recent_searches_text_view.setText(R.string.no_recent_searches);
-        Toast.makeText(getContext(), getString(R.string.search_history_deleted),
-            Toast.LENGTH_SHORT).show();
+        ViewUtil.showLongSnackbar(requireView(),getString(R.string.search_history_deleted));
         recentSearches = recentSearchesDao.recentSearches(10);
         adapter = new ArrayAdapter<>(context, R.layout.item_recent_searches,
             recentSearches);

app/src/main/java/fr/free/nrw/commons/feedback/FeedbackDialog.java

@@ -4,8 +4,6 @@
 import android.content.Context;
 import android.os.Bundle;
 import android.view.View;
-import android.view.View.OnClickListener;
-import android.widget.Toast;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.databinding.DialogFeedbackBinding;
 import fr.free.nrw.commons.feedback.model.Feedback;

app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.java

@@ -11,7 +11,6 @@
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.TextView;
-import android.widget.Toast;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AlertDialog;
@@ -34,6 +33,7 @@
 import fr.free.nrw.commons.profile.ProfileActivity;
 import fr.free.nrw.commons.review.ReviewActivity;
 import fr.free.nrw.commons.settings.SettingsActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
 import io.reactivex.Single;
 import io.reactivex.SingleSource;
 import io.reactivex.android.schedulers.AndroidSchedulers;
@@ -155,11 +155,9 @@ void uploadFeedback(final Feedback feedback) {
             .observeOn(AndroidSchedulers.mainThread())
             .subscribe(aBoolean -> {
                 if (aBoolean) {
-                    Toast.makeText(getContext(), getString(R.string.thanks_feedback), Toast.LENGTH_SHORT)
-                        .show();
+                    ViewUtil.showLongSnackbar(requireView(),getString(R.string.thanks_feedback));
                 } else {
-                    Toast.makeText(getContext(), getString(R.string.error_feedback),
-                        Toast.LENGTH_SHORT).show();
+                    ViewUtil.showLongSnackbar(requireView(),getString(R.string.error_feedback));
                 }
             });
     }
@@ -194,7 +192,7 @@ private void sendFeedback() {
         try {
             startActivity(feedbackIntent);
         } catch (final ActivityNotFoundException e) {
-            Toast.makeText(getActivity(), R.string.no_email_client, Toast.LENGTH_SHORT).show();
+            ViewUtil.showLongSnackbar(requireView(),getString(R.string.no_email_client));
         }
     }
 

app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.java

@@ -8,7 +8,6 @@
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
-import android.widget.Toast;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AlertDialog;
@@ -22,6 +21,7 @@
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.logging.CommonsLogSender;
 import fr.free.nrw.commons.settings.SettingsActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
 import javax.inject.Inject;
 import javax.inject.Named;
 import timber.log.Timber;
@@ -109,7 +109,7 @@ private void sendFeedback() {
         try {
             startActivity(feedbackIntent);
         } catch (final ActivityNotFoundException e) {
-            Toast.makeText(getActivity(), R.string.no_email_client, Toast.LENGTH_SHORT).show();
+            ViewUtil.showLongSnackbar(requireView(),getString(R.string.no_email_client));
         }
     }
 

app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java

@@ -14,7 +14,6 @@
 import android.widget.ImageView;
 import android.widget.ProgressBar;
 import android.widget.TextView;
-import android.widget.Toast;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AppCompatActivity;
@@ -37,6 +36,7 @@
 import fr.free.nrw.commons.upload.UploadBaseFragment;
 import fr.free.nrw.commons.upload.structure.depictions.DepictedItem;
 import fr.free.nrw.commons.utils.DialogUtil;
+import fr.free.nrw.commons.utils.ViewUtil;
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.disposables.Disposable;
 import java.util.List;
@@ -203,8 +203,7 @@ public void noDepictionSelected() {
                 null
             );
         } else {
-            Toast.makeText(requireContext(), getString(R.string.no_depictions_selected),
-                Toast.LENGTH_SHORT).show();
+            ViewUtil.showLongSnackbar(requireView(),getString(R.string.no_depictions_selected));
             presenter.clearPreviousSelection();
             updateDepicts();
             goBackToPreviousScreen();

app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java

@@ -7,7 +7,7 @@
 import android.net.Uri;
 import android.os.Build;
 import android.provider.Settings;
-import android.widget.Toast;
+import android.view.View;
 import androidx.annotation.StringRes;
 import androidx.core.content.ContextCompat;
 import com.karumi.dexter.Dexter;
@@ -176,10 +176,10 @@ public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissio
                         }
                         ,
                         () -> {
-                            Toast.makeText(activity.getApplicationContext(),
-                                    R.string.permissions_are_required_for_functionality,
-                                    Toast.LENGTH_LONG)
-                                .show();
+                            final View view = activity.findViewById(android.R.id.content);
+                            if (view != null){
+                                ViewUtil.showLongSnackbar(view,activity.getString(R.string.permissions_are_required_for_functionality));
+                            }
                             token.cancelPermissionRequest();
                             if (activity instanceof UploadActivity) {
                                 activity.finish();