Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data client simplification / removal #5507

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

psh
Copy link
Collaborator

@psh psh commented Feb 2, 2024

This PR is big - sorry! It happened over time as 3 distinct steps

  • Dead code removal (so I could see what needed to move)
  • Move used code into the main commons source tree
  • Delete the dead data-client

This PR relates to the discussion in #5165, and completes the overall cleanup. Our use of back-end APIs should now be clear if we choose to update them!

I love deleting code, but I have to admit I laughed with joy at seeing
image

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks! 🙂

@nicolas-raoul nicolas-raoul merged commit 0c30852 into commons-app:main Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants