Fix #5182 Switch From Mapbox to MapLibre #5184

kartikaykaushik14 · 2023-03-21T22:10:01Z

Description (required)

Fixes #5182

What changes did you make and why?

Migrated from Mapbox to MapLibre

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

nicolas-raoul

Code looks great!
I will try to test tomorrow.

nicolas-raoul · 2023-03-22T10:24:23Z

Meanwhile any idea why the unit tests testOnMapReady and testShowDetail fail?

nicolas-raoul · 2023-03-23T10:50:39Z

I am getting this crash:

03-23 19:49:07.328 26593 26593 E AndroidRuntime: java.lang.IllegalArgumentException: Could not find layer Outdoor
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.Style.getPredefinedStyle(Style.java:1430)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.lambda$onViewCreated$2$NearbyParentFragment(NearbyParentFragment.java:319)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at fr.free.nrw.commons.nearby.fragments.-$$Lambda$NearbyParentFragment$LW_iO-h3e6OvgddLCQ2oE4vXWAc.onMapReady(Unknown Source:2)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.MapView$MapCallback.onMapReady(MapView.java:1322)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.MapView$MapCallback.initialised(MapView.java:1308)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.MapView.initialiseMap(MapView.java:203)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.MapView.access$800(MapView.java:65)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.mapbox.mapboxsdk.maps.MapView$6.run(MapView.java:355)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:942)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:201)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7884)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
03-23 19:49:07.328 26593 26593 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

nicolas-raoul · 2023-03-23T10:58:02Z

Deleting the app's data solved the crash.
Maybe a kind of migraton is needed?

nicolas-raoul · 2023-03-23T13:12:32Z

I can consistently crash by switching from dark mode to light mode in the app's settings menu and coming back to the map. Can you reproduce?

kartikaykaushik14 · 2023-03-23T13:14:26Z

@nicolas-raoul I have identified the root cause for issue "Could not find layer Outdoor". Pushing a new patch with these changes

Ayan-10

It's having some issues with the dark UI. Screenshots are attached below.

kartikaykaushik14 · 2023-03-23T21:44:11Z

@Ayan-10 I'm able to reproduce the issue. Still trying to figure out what could be the root cause since I'm using Mapbox's predefined style for "Dark" just like "Outdoors" and "Streets".

MapLibre offers us the option to use Mapbox Configuration so I continued with it to maintain consistency. I checked the URL being called for the Dark Style and it is "mapbox://styles/mapbox/light-v10" which is consistent with that being called in the case of mapbox-sdk.

nicolas-raoul · 2023-03-24T06:00:17Z

Great, no more crash in Contributions now.

However, in addition to the visual issues reported by Ayan, I observe a crash in Explore: tap any picture, then tap the pen icon at the right of the latitude/longitude:

03-24 14:56:06.218 27280 27280 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons/fr.free.nrw.commons.LocationPicker.LocationPickerActivity}: android.util.AndroidRuntimeException: requestFeature() must be called before adding content
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3641)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3778)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2303)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:201)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7884)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: Caused by: android.util.AndroidRuntimeException: requestFeature() must be called before adding content
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at com.android.internal.policy.PhoneWindow.requestFeature(PhoneWindow.java:402)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.onCreate(LocationPickerActivity.java:147)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8341)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8320)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1417)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3622)
03-24 14:56:06.218 27280 27280 E AndroidRuntime: 	... 12 more

If possible, would you mind using normal push instead of force-push, unless really necessary? Thanks! :-)

kartikaykaushik14 · 2023-03-24T18:18:13Z

@nicolas-raoul Could you please check if the issue still persists?

Meanwhile, I'm trying to fix the dark mode issue.

Ayan-10 · 2023-03-24T19:38:49Z

The crash is not occurring for me anymore.

nicolas-raoul · 2023-03-25T06:59:07Z

No crash anymore indeed, thanks!

kartikaykaushik14 · 2023-03-28T03:03:42Z

@Ayan-10 I Just pushed some changes for the "About" and "Settings" screens on dark mode. Please let me know how to get to the 3rd screen with achievements and leaderboard. I can apply a similar fix and test.

nicolas-raoul · 2023-03-28T03:42:15Z

To see achievements, you must be logged-in, tap the app's hamburger menu, then tap the cup icon with your usename at the top of the menu.

I will test this branch from now, thanks!

nicolas-raoul · 2023-03-28T04:17:43Z

UI that appears bright in dark mode:

Achievements
Leaderboard (right tab next to achievements)
Review, also known as Peer Review, accessible from the hamburger menu
Background of the upload wizard, when the picture does not take the full space (not sure whether this works in master, so no need to worry if not related to your PR)

nicolas-raoul · 2023-03-28T06:22:07Z

I guess you have found out that the app has two flavors, beta and prod, matching https://commons.wikimedia.beta.wmflabs.org and https://commons.wikimedia.org.
We usually use prod even for development, unless we need to perform test uploads.

nicolas-raoul · 2023-03-28T08:06:53Z

Sorry I noticed a few more places with bright elements in dark mode:

Upload wizard license selection step:

Upload wizard location selection step:

Upload wizard first step:

Custom picker:

Hamburger menu → Feedback:

Nearby location alert, it seems to have a bright border, if it also happens in master then feel free to ignore:

Some of these screens are difficult to find, please let me know which ones you can't locate.

kartikaykaushik14 · 2023-03-29T03:57:02Z

Upload Wizard Media License - Working on it
Upload Wizard Location Selection Step - Looks the same in master
Upload Wizard First Step - Working on it
Custom Picker - Working on it
Feedback - Looks the same in master
Nearby Location Alert - Unable to verify this.

nicolas-raoul · 2023-03-29T09:29:52Z

Thanks! I created a different issue for (2) and (5).

For (6) you can use the "Fake GPS" app or similar to put yourself in a place that has many Wikidata items, for instance right on the Eiffel Tower. The banner should then appear within a minute.

kartikaykaushik14 · 2023-03-29T15:30:02Z

For 6) I observed the screen on Master as below -

Meanwhile, I observed the same bug on the Notifications screen and resolved it.

…tFeature() issue

…ode issue on two screens

…ode issue on additional screens

…ode issue on notification screen

nicolas-raoul

Works as intended, in both light and dark mode.
Code looks great, maybe some Strings could be made into constants, but no blocker.
Thanks a lot for implementing this very important change!

* feedback dialog: fix black font in dark mode * LocationPickerActivity: fix light map in dark mode * Fix #5182 Switch From Mapbox to MapLibre (#5184) * Fix #5182 Switch From Mapbox to MapLibre * Fix #5182 Switch From Mapbox to MapLibre - Resolved requestFeature() issue * Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on two screens * Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on additional screens * Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on notification screen * Fix #5182 Switch From Mapbox to MapLibre - Test errors * fix issue #5015 - custom image selector not identifying photo location (#5190) Co-authored-by: Siva <doodsiva@gmail.com> * feedback dialog: fix black font in dark mode * LocationPickerActivity: fix light map in dark mode * LocationPicker: use predefined style based on device theme * LocationPickerActivityTest: add additional target exception in catch block * LocationPickerConstants: remove extra newline introduced --------- Co-authored-by: Kartikay Kaushik <93285364+kartikaykaushik14@users.noreply.github.com> Co-authored-by: Siva Subramaniam <112970189+siva-subramaniam-v@users.noreply.github.com> Co-authored-by: Siva <doodsiva@gmail.com>

kartikaykaushik14 force-pushed the bug#4994 branch from 2a0b823 to cf86367 Compare March 21, 2023 23:43

nicolas-raoul reviewed Mar 22, 2023

View reviewed changes

kartikaykaushik14 force-pushed the bug#4994 branch from cf86367 to 588c256 Compare March 23, 2023 13:17

Ayan-10 reviewed Mar 23, 2023

View reviewed changes

kartikaykaushik14 force-pushed the bug#4994 branch from a6f4ad6 to bdb2355 Compare March 29, 2023 04:44

kartikaykaushik14 added 5 commits March 29, 2023 18:04

Fix commons-app#5182 Switch From Mapbox to MapLibre

00fcbf6

Fix commons-app#5182 Switch From Mapbox to MapLibre - Resolved reques…

d440ef6

…tFeature() issue

Fix commons-app#5182 Switch From Mapbox to MapLibre - Resolved dark m…

433a9b8

…ode issue on two screens

Fix commons-app#5182 Switch From Mapbox to MapLibre - Resolved dark m…

0f91260

…ode issue on additional screens

Fix commons-app#5182 Switch From Mapbox to MapLibre - Resolved dark m…

874f05a

…ode issue on notification screen

kartikaykaushik14 force-pushed the bug#4994 branch from 6a28088 to 874f05a Compare March 29, 2023 22:04

Fix commons-app#5182 Switch From Mapbox to MapLibre - Test errors

a532672

kartikaykaushik14 requested a review from nicolas-raoul March 30, 2023 21:28

nicolas-raoul approved these changes Mar 31, 2023

View reviewed changes

nicolas-raoul merged commit 8f8dcc0 into commons-app:master Mar 31, 2023

kartikaykaushik14 deleted the bug#4994 branch March 31, 2023 00:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #5182 Switch From Mapbox to MapLibre #5184

Fix #5182 Switch From Mapbox to MapLibre #5184

kartikaykaushik14 commented Mar 21, 2023 •

edited

Loading

nicolas-raoul left a comment

nicolas-raoul commented Mar 22, 2023

nicolas-raoul commented Mar 23, 2023

nicolas-raoul commented Mar 23, 2023

nicolas-raoul commented Mar 23, 2023

kartikaykaushik14 commented Mar 23, 2023 •

edited

Loading

Ayan-10 left a comment

kartikaykaushik14 commented Mar 23, 2023

nicolas-raoul commented Mar 24, 2023

kartikaykaushik14 commented Mar 24, 2023

Ayan-10 commented Mar 24, 2023

nicolas-raoul commented Mar 25, 2023

kartikaykaushik14 commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023 •

edited

Loading

kartikaykaushik14 commented Mar 29, 2023 •

edited

Loading

nicolas-raoul commented Mar 29, 2023 •

edited

Loading

kartikaykaushik14 commented Mar 29, 2023

nicolas-raoul left a comment

Fix #5182 Switch From Mapbox to MapLibre #5184

Fix #5182 Switch From Mapbox to MapLibre #5184

Conversation

kartikaykaushik14 commented Mar 21, 2023 • edited Loading

nicolas-raoul left a comment

Choose a reason for hiding this comment

nicolas-raoul commented Mar 22, 2023

nicolas-raoul commented Mar 23, 2023

nicolas-raoul commented Mar 23, 2023

nicolas-raoul commented Mar 23, 2023

kartikaykaushik14 commented Mar 23, 2023 • edited Loading

Ayan-10 left a comment

Choose a reason for hiding this comment

kartikaykaushik14 commented Mar 23, 2023

nicolas-raoul commented Mar 24, 2023

kartikaykaushik14 commented Mar 24, 2023

Ayan-10 commented Mar 24, 2023

nicolas-raoul commented Mar 25, 2023

kartikaykaushik14 commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023

nicolas-raoul commented Mar 28, 2023 • edited Loading

kartikaykaushik14 commented Mar 29, 2023 • edited Loading

nicolas-raoul commented Mar 29, 2023 • edited Loading

kartikaykaushik14 commented Mar 29, 2023

nicolas-raoul left a comment

Choose a reason for hiding this comment

kartikaykaushik14 commented Mar 21, 2023 •

edited

Loading

kartikaykaushik14 commented Mar 23, 2023 •

edited

Loading

nicolas-raoul commented Mar 28, 2023 •

edited

Loading

kartikaykaushik14 commented Mar 29, 2023 •

edited

Loading

nicolas-raoul commented Mar 29, 2023 •

edited

Loading