Fixes #545 - Add support for campaigns #4423

ashishkumar468 · 2021-05-22T15:39:56Z

Description (required)
Query Wikidata to fetch monuments and show them in Nearby
Fixes #545

What changes did you make and why?

Add query for monuments
Make an API call to fetch monuments
Attach the list of monuments with nearby places response and render the monuments on the Map along with other nearby items

Tests performed (required)
Tested the build prodDebug on the local emulator.- Able to see monuments for location (50.9709677364145, 22.776031494140625)

Feature

Screenshots (for UI changes only)

codecov-commenter · 2021-05-22T15:51:30Z

Codecov Report

Merging #4423 (9a0b3bf) into master (b6ffe9f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4423      +/-   ##
============================================
- Coverage     10.34%   10.29%   -0.06%     
  Complexity      479      479              
============================================
  Files           342      342              
  Lines         13201    13269      +68     
  Branches       1083     1089       +6     
============================================
  Hits           1366     1366              
- Misses        11766    11834      +68     
  Partials         69       69

Impacted Files	Coverage Δ	Complexity Δ
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...a/fr/free/nrw/commons/nearby/NearbyController.java	`2.70% <0.00%> (-0.24%)`	`1.00 <0.00> (ø)`
.../java/fr/free/nrw/commons/nearby/NearbyPlaces.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...rc/main/java/fr/free/nrw/commons/nearby/Place.java	`15.85% <0.00%> (-0.61%)`	`4.00 <0.00> (ø)`
...commons/nearby/fragments/NearbyParentFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ffe9f...9a0b3bf. Read the comment docs.

- Show monuments in maps along with nearby

misaochan · 2021-07-12T08:57:00Z

Hi @ashishkumar468 ,

I have been trying to test this PR, but have encountered a few roadblocks. I am running a Samsung Galaxy S20 FE on Android 11.

There is no WLM banner displayed - I know it's not September yet, but the campaign should be hardcoded to "active" during this testing period?
So I access Nearby the usual way. As it is a fresh install, I am prompted for location permissions. I accept "While using the app". However the progress bar never stops loading - I attached a screenshot below. There is also an unmarshalling exception that may be related to this, attached logs below.

2021-07-12 18:50:45.491 15623-15623/fr.free.nrw.commons E/Parcel: Class not found when unmarshalling: com.google.android.gms.location.LocationResult
    java.lang.ClassNotFoundException: com.google.android.gms.location.LocationResult
        at java.lang.Class.classForName(Native Method)
        at java.lang.Class.forName(Class.java:454)
        at android.os.Parcel.readParcelableCreator(Parcel.java:3350)
        at android.os.Parcel.readParcelable(Parcel.java:3284)
        at android.os.Parcel.readValue(Parcel.java:3186)
        at android.os.Parcel.readArrayMapInternal(Parcel.java:3579)
        at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:292)
        at android.os.BaseBundle.unparcel(BaseBundle.java:236)
        at android.os.BaseBundle.containsKey(BaseBundle.java:516)
        at android.content.Intent.hasExtra(Intent.java:8699)
        at com.mapbox.android.core.location.LocationEngineResult.hasResult(LocationEngineResult.java:107)
        at com.mapbox.android.core.location.LocationEngineResult.extractAndroidResult(LocationEngineResult.java:101)
        at com.mapbox.android.core.location.LocationEngineResult.extractResult(LocationEngineResult.java:92)
        at com.mapbox.android.telemetry.location.LocationUpdatesBroadcastReceiver.onReceive(LocationUpdatesBroadcastReceiver.java:35)
        at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1666)
        at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:246)
        at android.app.ActivityThread.main(ActivityThread.java:8506)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.gms.location.LocationResult" on path: DexPathList[[zip file "/data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/base.apk"],nativeLibraryDirectories=[/data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/lib/arm64, /data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/base.apk!/lib/arm64-v8a, /system/lib64, /system/system_ext/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:207)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at java.lang.Class.classForName(Native Method) 
        at java.lang.Class.forName(Class.java:454) 
        at android.os.Parcel.readParcelableCreator(Parcel.java:3350) 
        at android.os.Parcel.readParcelable(Parcel.java:3284) 
        at android.os.Parcel.readValue(Parcel.java:3186) 
        at android.os.Parcel.readArrayMapInternal(Parcel.java:3579) 
        at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:292) 
        at android.os.BaseBundle.unparcel(BaseBundle.java:236) 
        at android.os.BaseBundle.containsKey(BaseBundle.java:516) 
        at android.content.Intent.hasExtra(Intent.java:8699) 
        at com.mapbox.android.core.location.LocationEngineResult.hasResult(LocationEngineResult.java:107) 
        at com.mapbox.android.core.location.LocationEngineResult.extractAndroidResult(LocationEngineResult.java:101) 
        at com.mapbox.android.core.location.LocationEngineResult.extractResult(LocationEngineResult.java:92) 
        at com.mapbox.android.telemetry.location.LocationUpdatesBroadcastReceiver.onReceive(LocationUpdatesBroadcastReceiver.java:35) 
        at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1666) 
        at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2) 
        at android.os.Handler.handleCallback(Handler.java:938) 
        at android.os.Handler.dispatchMessage(Handler.java:99) 
        at android.os.Looper.loop(Looper.java:246) 
        at android.app.ActivityThread.main(ActivityThread.java:8506) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130) 
2021-07-12 18:50:45.491 15623-15623/fr.free.nrw.commons E/LocationUpdateReceiver: android.os.BadParcelableException: ClassNotFoundException when unmarshalling: com.google.android.gms.location.LocationResult
2021-07-12 18:50:50.713 15623-15623/fr.free.nrw.commons E/Parcel: Class not found when unmarshalling: com.google.android.gms.location.LocationResult
    java.lang.ClassNotFoundException: com.google.android.gms.location.LocationResult
        at java.lang.Class.classForName(Native Method)
        at java.lang.Class.forName(Class.java:454)
        at android.os.Parcel.readParcelableCreator(Parcel.java:3350)
        at android.os.Parcel.readParcelable(Parcel.java:3284)
        at android.os.Parcel.readValue(Parcel.java:3186)
        at android.os.Parcel.readArrayMapInternal(Parcel.java:3579)
        at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:292)
        at android.os.BaseBundle.unparcel(BaseBundle.java:236)
        at android.os.BaseBundle.containsKey(BaseBundle.java:516)
        at android.content.Intent.hasExtra(Intent.java:8699)
        at com.mapbox.android.core.location.LocationEngineResult.hasResult(LocationEngineResult.java:107)
        at com.mapbox.android.core.location.LocationEngineResult.extractAndroidResult(LocationEngineResult.java:101)
        at com.mapbox.android.core.location.LocationEngineResult.extractResult(LocationEngineResult.java:92)
        at com.mapbox.android.telemetry.location.LocationUpdatesBroadcastReceiver.onReceive(LocationUpdatesBroadcastReceiver.java:35)
        at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1666)
        at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:246)
        at android.app.ActivityThread.main(ActivityThread.java:8506)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.gms.location.LocationResult" on path: DexPathList[[zip file "/data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/base.apk"],nativeLibraryDirectories=[/data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/lib/arm64, /data/app/~~RSmKKRT0IFSE8K51sZ8wag==/fr.free.nrw.commons-AneDxkbXOovvzM-4kZHYuw==/base.apk!/lib/arm64-v8a, /system/lib64, /system/system_ext/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:207)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at java.lang.Class.classForName(Native Method) 
        at java.lang.Class.forName(Class.java:454) 
        at android.os.Parcel.readParcelableCreator(Parcel.java:3350) 
        at android.os.Parcel.readParcelable(Parcel.java:3284) 
        at android.os.Parcel.readValue(Parcel.java:3186) 
        at android.os.Parcel.readArrayMapInternal(Parcel.java:3579) 
        at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:292) 
        at android.os.BaseBundle.unparcel(BaseBundle.java:236) 
        at android.os.BaseBundle.containsKey(BaseBundle.java:516) 
        at android.content.Intent.hasExtra(Intent.java:8699) 
        at com.mapbox.android.core.location.LocationEngineResult.hasResult(LocationEngineResult.java:107) 
        at com.mapbox.android.core.location.LocationEngineResult.extractAndroidResult(LocationEngineResult.java:101) 
        at com.mapbox.android.core.location.LocationEngineResult.extractResult(LocationEngineResult.java:92) 
        at com.mapbox.android.telemetry.location.LocationUpdatesBroadcastReceiver.onReceive(LocationUpdatesBroadcastReceiver.java:35) 
        at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1666) 
        at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2) 
        at android.os.Handler.handleCallback(Handler.java:938) 
        at android.os.Handler.dispatchMessage(Handler.java:99) 
        at android.os.Looper.loop(Looper.java:246) 
        at android.app.ActivityThread.main(ActivityThread.java:8506) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130) 
2021-07-12 18:50:50.713 15623-15623/fr.free.nrw.commons E/LocationUpdateReceiver: android.os.BadParcelableException: ClassNotFoundException when unmarshalling: com.google.android.gms.location.LocationResult

I cannot get any points to display at all, the progress bar just loads forever. I tried manually moving to my location on the map and tapping "search this area", but with the same result. Tried another area and same result. Tried switching between different activities, same result. Killing and restarting app, same result.

On the other hand, I just tried v3.0.2 Nearby and that works fine for me on the same device.

ashishkumar468 · 2021-07-12T08:58:56Z

@misaochan I will look into it, for now can you try a different device. Also, you would need to enable the wlm from the settings.

misaochan · 2021-07-12T09:06:17Z

Tried with emulator, Pixel 3a running Android 10, encountered the same issue. :/

neslihanturan · 2021-07-14T09:44:37Z

Thanks for the PR @ashishkumar468 :) I have tested it. At first the campaign setting was off but WLM setting was on. With these settings no campaign banner appeared and nearby loads forever (even pins didn't appear).
On my second attempt I made both campaign and WLM setting on. Then I was able to see the setting. Nearby pins loaded with no problem. However I don't see any pins with WLM logo even at the location that you shared. I didn't experience any crash. Also I recognized some UI issues that WLM logo on campaign doesn't fit, search this area button conflicts with it is WLM month notice.

misaochan · 2021-07-14T14:53:22Z

Thanks for testing @neslihanturan !

@ashishkumar468 I was unaware that there were 2 separate settings. Aside from the issues Neslihan mentioned, I also think we should consolidate both into one setting - campaigns should automatically include WLM. If a separate flag is needed for testing WLM, I think we should just hardcode it to "on" for testing purposes for the time being.

Also, I think we all agreed that the WLM banner in Contributions should just utilize the existing design (for campaign cards), right? :) It is just the functionality that we are changing - if the user taps on the banner they should be brought to Nearby.

misaochan · 2021-07-15T08:15:45Z

Tested again today with Neslihan's method (both campaign and WLM setting turned to on), it works for me! Will consolidate my feedback below with a checklist:

As mentioned by Neslihan, the UI of the Contributions card needs to change - use the old design and text, but send the user to Nearby when they tap on it. For reference, the design should be the same as the design implemented Show campaigns #2113 , and the text should be: "Wiki Loves Monuments 1 Sep - 31 Oct".
The banner in Nearby should say "It's Wiki Loves Monuments month!". There is a typo in the current banner. ;)
I am able to view monuments in my area! Great job @ashishkumar468 . :) However, if a monument overlaps with a "Needs Photos" pin, both pins are shown - in that case I think the Needs Photos pin should be hidden.
(Optional) Also, I understand that this is slightly out of scope, but with the addition of the WLM place state chip, the filter now takes up a large amount of screen real estate, see Screenshot 1. If possible, would be great to have a button that minimizes the card when tapped, similar to the "^" button in Step 1 of the upload process.
Unfortunately when I leave Nearby and go to Contributions, then back to Nearby, the same unmarshaling exception as above occurs and Nearby loads forever. In order to fix this I must kill the app and restart it. This happens every time I leave Nearby activity, without fail.
There seems to be an issue with the details displayed for all pins (both WLM and non-WLM), see Screenshot 2. The place details (after expanding the bottom sheet) only displays a repeat of the item name. For non-WLM pins this should follow the convention implemented at Fix #4147 Pre-fill desc in Nearby uploads with Wikidata item's label + description #4390 , and for WLM pins this should display the address.
When uploading a monument, the description is prefilled again with only the monument name (see Screenshot 3). As discussed, for WLM monuments this should be monument-name + (address from P6375). For non-WLM uploads we should follow the convention at Fix #4147 Pre-fill desc in Nearby uploads with Wikidata item's label + description #4390 .
I uploaded https://commons.wikimedia.org/wiki/File:New_Farm_Park_3.jpg . The template itself seems to work and it says "This image was uploaded as part of Wiki Loves Monuments 2021", nice! However, it also says:

English: No or incorrect country code indicated in the {{Wiki Loves Monuments 2021}} template
Deutsch: Kein oder fehlerhafer Ländercode in der {{Wiki Loves Monuments 2021}}-Vorlage angegeben
}}"

The summary says |1= AUS, which isn't the right ISO. We need the ISO2 code, not ISO3. Would https://developer.android.com/reference/java/util/Locale#getISOCountries() work?

As discussed, I would recommend using a sandbox "monument" for testing template additions, as suggested by @nicolas-raoul at #545 (comment) . @nicolas-raoul , do you know how we can add P1435 and also a location, to the sandbox Wikidata item that you mentioned? I'm not sure how to add Wikidata properties.

Screenshot 1:

Screenshot 2:

Screenshot 3:

nicolas-raoul · 2021-07-15T09:39:17Z

I added heritage designation and coordinate location statements to the sandbox Wikidata item using the + add statement button :-)

misaochan · 2021-07-15T11:01:51Z

Thanks a lot @nicolas-raoul ! For some reason I didn't think to scroll all the way down... :)

neslihanturan · 2021-08-03T10:21:05Z

Hey @misaochan , I have tested it under Android 11 Nexus 6 device. Search this area button worked well and WLM markers appeared:

… monuments - [P1435, P2186, P1459, P1460, P1216, P709, P718, P5694] 2. Append WikiData QID to descriptions template

misaochan · 2021-08-10T13:51:25Z

app/src/main/res/values/strings.xml

+  <string name="display_monuments">Display monuments</string>
+  <string name="wlm_month_message">It\'s Wiki Loves Monuments month!</string>
+  <string name="learn_more">LEARN MORE</string>
+  <string name="wlm_campaign_title">Its WML season</string>


Should just say "Wiki Loves Monuments"

misaochan · 2021-08-10T14:02:53Z

Tried testing again today on my real device, a few notes:

Cleaning the build has not solved my "Search this area" issue. So I cannot test for the union of other property types, as the ones near my place only use P1435. Hopefully @neslihanturan will be able to. (Hint: You just need to check both Ireland and Australia, as they use different properties - P2186 for Ireland and P1435 for Australia. You should be able to see WLM markers for both.). Edit: Managed to make it work on my emulator, and it seems to function as intended, but the map on my emulator has always had a strange rendering issue that makes it difficult to see the pins, so best to verify.
The QID addition works great!
The country template should be right but I am still getting the same error https://commons.wikimedia.org/wiki/File:Newstead_Gasworks_4.jpg#%7B%7Bint%3Afiledesc%7D%7D even after manually switching to a country that is actually on https://commons.wikimedia.org/wiki/Template:Wiki_Loves_Monuments_country_logos . Interestingly some countries like "ie" work, and others like "al" don't. I asked on mailing list, waiting for response.
These issues still exist:

There seems to be an issue with the details displayed for all pins (both WLM and non-WLM), see Screenshot 2. The place details (after expanding the bottom sheet) only displays a repeat of the item name. For non-WLM pins this should follow the convention implemented at Fix #4147 Pre-fill desc in Nearby uploads with Wikidata item's label + description #4390 , and for WLM pins this should display the address.

When uploading a monument, the description is prefilled again with only the monument name (see Screenshot 3). As discussed, for WLM monuments this should be monument-name + (address from P6375). For non-WLM uploads we should follow the convention at Fix #4147 Pre-fill desc in Nearby uploads with Wikidata item's label + description #4390 .

Once we are done with testing (after this PR is merged), we need to:

Stop hardcoding the dates, only make everything appear from 1 Sep to 31 Oct. Since we have stopped auto-publishing alpha, I might actually do a release to alpha prior to this, so that alpha is always testable (but beta and production would only have the banner appear at the right time)

neslihanturan · 2021-08-12T11:37:04Z

Hey @misaochan , it worked for me with search this area for Ireland and Australia with pyhsical Android10 device. Here are screenshoots:

ashishkumar468 · 2021-08-14T15:36:43Z

Hi @misaochan , the usual Nearby items, do show the pre-filled desc as they used to before. For the WLM pins, as I have mentioned before, the P6375 used for the "streetAddress" does not return anything for my location, attaching a sample response, and therefore that field in the details or in the Upload step is omitted.

Sharing a sample response for WLM query - https://gist.github.com/ashishkumar468/5d2eac4844d3c5c600de467e2558c6cb

As you can see the streetAddress property is empty.

…, continue showing the nearby items if that succeeds

misaochan · 2021-08-16T08:36:18Z

Notes from discussions (on Zulip and mailing lists) and tests:

We have decided that due to the frequent lack of P6375, we will just use the standard label+desc used in non-WLM points for WLM points as well
"Search this area" works now! However, it takes much longer than it used to, probably due to the large number of WLM points. We are trying to figure out an easy fix for this that works in time for the competition.
Some country codes are not working because the codes allowed are defined at https://commons.wikimedia.org/w/index.php?title=Template:Wiki_Loves_Monuments_2021&action=edit . For now we can do nothing. Closer to the start date the actions are detailed at When participating countries have been fixed for WLM, release update with template inclusions #4554

misaochan · 2021-08-17T11:13:38Z

Made separate issues for everything else. Only thing pending for merge is "We have decided that due to the frequent lack of P6375, we will just use the standard label+desc used in non-WLM points for WLM points as well".

…ead of relying on P6375

misaochan · 2021-08-18T08:27:21Z

Great job, @ashishkumar468 ! Merging :)

ashishkumar468 force-pushed the wlm branch 2 times, most recently from 9b19464 to b91355e Compare June 23, 2021 03:12

ashishkumar468 force-pushed the wlm branch 14 times, most recently from d87b663 to bbe2b6b Compare July 8, 2021 18:01

ashishkumar468 marked this pull request as ready for review July 8, 2021 18:02

Integrate WLM

4b1722f

- Show monuments in maps along with nearby

ashishkumar468 self-assigned this Jul 10, 2021

ashishkumar468 force-pushed the wlm branch from bbe2b6b to 4b1722f Compare July 10, 2021 08:06

ashishkumar468 changed the title ~~[WIP]Fixes #545 - Add support for campaigns~~ Fixes #545 - Add support for campaigns Jul 10, 2021

Bug-Fix, WLM Campaign Icon

cee1006

1. Updated monuments query to use any of the following properties for…

6171f5f

… monuments - [P1435, P2186, P1459, P1460, P1216, P709, P718, P5694] 2. Append WikiData QID to descriptions template

misaochan reviewed Aug 10, 2021

View reviewed changes

This was referenced Aug 12, 2021

Permanent "uploading file" notification even though file has already been uploaded #4547

Closed

After merging WLM integration, do alpha release and then set date constraints #4552

Closed

Updated WLM Banner String, Handle NPE in contributions callback

1a7c760

ashishkumar468 added 4 commits August 14, 2021 21:20

Added nearby-monuments query log lines

bf753ca

Handle WLM Query exception : - if an exception is thrown in WLM query…

b3dea30

…, continue showing the nearby items if that succeeds

Fix BookmarkLocationDaoTest

2821d80

Added Column Address in BookmarkLocationDaoTest

2428d0f

misaochan mentioned this pull request Aug 17, 2021

Searching area with high density of WLM pins takes a very long time #4558

Closed

ashishkumar468 added 10 commits August 17, 2021 20:27

Use fallback description as usual nearby pins even for WLM pins, inst…

84561dc

…ead of relying on P6375

Test fix in BookmarkLocationDao

e919590

Updated template for WLM, removed redundant feilds

35af80b

Fixed WLM template

49e8e12

Removed categories from WLM template

bf603f7

Fixed BookmarkControllerTest

530bd46

Fixed BookmarkLocationFragmentUnitTest

ed82456

fix ModelFunctions

c98d746

Fixed BookmarksDaoLocationTest

6dfbfef

Fixed WLM template

f200539

misaochan merged commit 6588a6f into commons-app:master Aug 18, 2021

misaochan mentioned this pull request Aug 18, 2021

Add support for campaigns #545

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #545 - Add support for campaigns #4423

Fixes #545 - Add support for campaigns #4423

ashishkumar468 commented May 22, 2021 •

edited by misaochan

Loading

codecov-commenter commented May 22, 2021

misaochan commented Jul 12, 2021 •

edited

Loading

ashishkumar468 commented Jul 12, 2021

misaochan commented Jul 12, 2021

neslihanturan commented Jul 14, 2021

misaochan commented Jul 14, 2021 •

edited

Loading

misaochan commented Jul 15, 2021 •

edited

Loading

nicolas-raoul commented Jul 15, 2021

misaochan commented Jul 15, 2021

neslihanturan commented Aug 3, 2021

misaochan Aug 10, 2021

misaochan commented Aug 10, 2021 •

edited

Loading

neslihanturan commented Aug 12, 2021

ashishkumar468 commented Aug 14, 2021 •

edited

Loading

misaochan commented Aug 16, 2021 •

edited

Loading

misaochan commented Aug 17, 2021

misaochan commented Aug 18, 2021

Fixes #545 - Add support for campaigns #4423

Fixes #545 - Add support for campaigns #4423

Conversation

ashishkumar468 commented May 22, 2021 • edited by misaochan Loading

codecov-commenter commented May 22, 2021

Codecov Report

misaochan commented Jul 12, 2021 • edited Loading

ashishkumar468 commented Jul 12, 2021

misaochan commented Jul 12, 2021

neslihanturan commented Jul 14, 2021

misaochan commented Jul 14, 2021 • edited Loading

misaochan commented Jul 15, 2021 • edited Loading

nicolas-raoul commented Jul 15, 2021

misaochan commented Jul 15, 2021

neslihanturan commented Aug 3, 2021

misaochan Aug 10, 2021

Choose a reason for hiding this comment

misaochan commented Aug 10, 2021 • edited Loading

neslihanturan commented Aug 12, 2021

ashishkumar468 commented Aug 14, 2021 • edited Loading

misaochan commented Aug 16, 2021 • edited Loading

misaochan commented Aug 17, 2021

misaochan commented Aug 18, 2021

ashishkumar468 commented May 22, 2021 •

edited by misaochan

Loading

misaochan commented Jul 12, 2021 •

edited

Loading

misaochan commented Jul 14, 2021 •

edited

Loading

misaochan commented Jul 15, 2021 •

edited

Loading

misaochan commented Aug 10, 2021 •

edited

Loading

ashishkumar468 commented Aug 14, 2021 •

edited

Loading

misaochan commented Aug 16, 2021 •

edited

Loading