Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) #3686

ashishkumar468 · 2020-04-21T06:19:27Z

Description (required)

What changes did you make and why?
CheckBox's custom saved state was not being Parcealized properly

Removed custom save state implementation of CheckBoxTriState
Save/Restore CheckBox state in NearbyParentFragment

Tests performed (required)

Tested betaDebug on Samsung S7 with "Don't Keep Activities" enabled in developer mode with the steps mentioned in the issue

* Removed custom save state implementatio of CheckBoxTriState * Save/Restore CheckBox state in NearbyParentFragment

tests-checker

Could you please add tests to make sure this change works as expected?

macgills · 2020-04-21T08:11:28Z

2020-04-21 09:10:27.767 9436-9436/fr.free.nrw.commons.beta E/ACRA: ACRA caught a RuntimeException for fr.free.nrw.commons.beta
    java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons.beta/fr.free.nrw.commons.contributions.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at fr.free.nrw.commons.nearby.CheckBoxTriStates.setState(CheckBoxTriStates.java:93)
        at fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.onViewCreated(NearbyParentFragment.java:228)

crashes when restoring the state

neslihanturan

I couldn't reproduce the issue, even with mentioned developer option is set.

macgills · 2020-04-21T15:58:40Z

click on the tricheckstate button a few times, apologies, should have mentioned more explicitly

neslihanturan

    java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at fr.free.nrw.commons.nearby.CheckBoxTriStates.setState(CheckBoxTriStates.java:93)
        at fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.onViewCreated(NearbyParentFragment.java:228)

After @macgills 's warnings, I also could reproduce the issue :/

ashishkumar468 · 2020-04-21T18:36:49Z

Thanks for testing the PR @neslihanturan & @macgills. I have added the fix for the exception, tested the app with a few clicks here and there. Please review the PR again.

codecov-io · 2020-04-21T18:42:16Z

Codecov Report

Merging #3686 into 2.13-release will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##             2.13-release   #3686      +/-   ##
=================================================
- Coverage            6.95%   6.94%   -0.01%     
+ Complexity            291     289       -2     
=================================================
  Files                 256     256              
  Lines               11733   11713      -20     
  Branches              959     960       +1     
=================================================
- Hits                  816     814       -2     
+ Misses              10846   10828      -18     
  Partials               71      71

Impacted Files	Coverage Δ	Complexity Δ
.../fr/free/nrw/commons/nearby/CheckBoxTriStates.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...commons/nearby/fragments/NearbyParentFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../fr/free/nrw/commons/category/CategoriesModel.java	`31.50% <0.00%> (-6.85%)`	`8.00% <0.00%> (-3.00%)`
...ava/fr/free/nrw/commons/category/CategoryItem.java	`22.22% <0.00%> (ø)`	`3.00% <0.00%> (ø%)`
...va/fr/free/nrw/commons/filepicker/PickedFiles.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...fr/free/nrw/commons/media/MediaDetailFragment.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...ava/fr/free/nrw/commons/utils/CommonsDateUtil.java	`85.71% <0.00%> (+42.85%)`	`2.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d6c52...95507bc. Read the comment docs.

macgills · 2020-04-22T08:16:41Z

@ashishkumar468 still crashing with same repro steps

2020-04-22 09:14:14.462 12885-12885/fr.free.nrw.commons.beta E/ACRA: ACRA caught a RuntimeException for fr.free.nrw.commons.beta
    java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons.beta/fr.free.nrw.commons.contributions.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at fr.free.nrw.commons.nearby.CheckBoxTriStates.setState(CheckBoxTriStates.java:93)

neslihanturan

It did not failed for me this time

neslihanturan · 2020-04-22T08:18:56Z

@ashishkumar468 still crashing with same repro steps

2020-04-22 09:14:14.462 12885-12885/fr.free.nrw.commons.beta E/ACRA: ACRA caught a RuntimeException for fr.free.nrw.commons.beta
    java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons.beta/fr.free.nrw.commons.contributions.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at fr.free.nrw.commons.nearby.CheckBoxTriStates.setState(CheckBoxTriStates.java:93)

Did I missed some steps to reproduce it again? will check the issue page instead of relying on my memory

neslihanturan

Yeah, after playing wit checkbox states I also still can reproduce it:

    java.lang.NullPointerException: Attempt to invoke interface method 'void fr.free.nrw.commons.nearby.CheckBoxTriStates$Callback.filterByMarkerType(java.util.List, int, boolean, boolean)' on a null object reference
        at fr.free.nrw.commons.nearby.CheckBoxTriStates.setState(CheckBoxTriStates.java:93)
        at fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.onViewCreated(NearbyParentFragment.java:228)

ashishkumar468 · 2020-04-22T08:28:29Z

@macgills @neslihanturan Just to confirm, the exact steps to reproduce are turn on don't keep activities, open the app, press home->come back go to nearby, play with the checkbox tri-state?. Did I miss anything?

neslihanturan · 2020-04-22T08:35:10Z

You should play with checkboxtristate at beginning. Press the home button of the phone, not home of the app, then return back to the app.

…called before onViewRestored sometimes

neslihanturan

After your last commit, it does not crash for me anymore:)

macgills · 2020-04-22T10:24:22Z

The semantics of the original, albeit broken, code have been changed. There was an explicit isRestoring flag that prevented the callback being invoked when restoring state so if this state restoration ever worked I assume this played a role.

When the screen gets recreates the state is not preserved on the UX level
Here I have deselected All

Then I recreate the screen (quite odd for a few reasons)

and then I tap place type

macgills · 2020-04-22T10:27:17Z

It isn't exactly good practice but we can just not restore the state, create a tech debt ticket and move on with the release @misaochan

ashishkumar468 · 2020-04-22T15:30:41Z

@macgills I think I might be able to preserve the checkbox state and solve the crash, working on it, will push the changes soon

ashishkumar468 · 2020-04-22T16:51:37Z

I seem to have found the fix, @macgills @neslihanturan. Please verify, sorry for the trouble :)

macgills · 2020-04-23T08:23:04Z

I think we should removing the state saving.

Sure the checkbox remembers its visual state but look at the map

It doesn't respect the state of the checkbox so it is meaningless

ashishkumar468 · 2020-04-23T09:27:53Z

Fair point @macgills, I am okay to remove the state saving, let's have some more insights @neslihanturan @misaochan @maskaravivek

misaochan · 2020-04-23T10:55:39Z

I am personally okay with not saving the state for now and just fixing the crash for the release. It is better than having filters that don't actually affect the pins on the map, and better than users crashing.

Let us wait for @neslihanturan 's input, and if she is okay with it we can proceed.

neslihanturan · 2020-04-23T11:02:08Z

I also think not saving the state for now as soon as the issue is fixed.
Not for the future: Later we can discuss to restore this state because I remember I tried to find a clean way to do it during nearby migration, and I couldn't because it is not just all/none checkbox we need to restore or not, there is also placestates we need to consider.

ashishkumar468 · 2020-04-23T17:01:52Z

Hi, @neslihanturan @macgills I have pushed the discussed changes, please have a look

macgills · 2020-04-24T07:50:27Z

.idea/codeStyles/codeStyleConfig.xml

@@ -1,5 +1,6 @@
 <component name="ProjectCodeStyleConfiguration">
  <state>
    <option name="USE_PER_PROJECT_SETTINGS" value="true" />
+    <option name="PREFERRED_PROJECT_CODE_STYLE" value="Default" />


https://youtrack.jetbrains.com/issue/IDEA-207303#focus=streamItem-27-3299338.0-0 so I think this comment has the solution to this line appearing

Thanks, fixing this

macgills · 2020-04-24T07:52:09Z

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java

@@ -118,8 +118,9 @@

 public class NearbyParentFragment extends CommonsDaggerSupportFragment
        implements NearbyParentFragmentContract.View,
-        WikidataEditListener.WikidataP18EditListener, LocationUpdateListener {
+        WikidataEditListener.WikidataP18EditListener, LocationUpdateListener ,CheckBoxTriStates.Callback{


I would expect zero changes to this file, if we just remove the state restoration in CheckboxTriState that is the minimal change to solve this issue

@macgills We have removed the manual state restoration thing, but the android system also restores the view right so if we don't set the callback in such cases, it will throw an NPE, right?

This is called on master after onViewCreated

checkBoxTriStates.setCallback((o, state, b, b1) -> presenter.filterByMarkerType(o,state,b,b1));

There was an internal problem where the checkbox will throw an NPE if you don't set a click listener to it and it processes a click event, that should not be the case. That problem arose because the state restoration was happening before the click listener was set and your version of state restoration didn't use the isRestoring flag to prevent the state restoration being interpreted as human input.

I am still halfway through my morning coffee, that wasn't a great explanation...

I'll perk up in a bit if you have any questions

Fair point, done

neslihanturan · 2020-04-26T09:04:50Z

Thanks @ashishkumar468 !

* #3624 DateTimeFormat wrong - match pattern returned from servers (#3625) * Revert "Fixes: #3179 Make category search non case-sensitive (#3326)" (#3636) Simply lower casing the name of the category sent to the server doesn't result in the server doing a case insensitive category search. In fact, it reduces the category search space as only categories that has a lower case character is searched even if the search text contains upper case characters. The test case did not catch this issue as the first character of the title is case insensitive[1]. So, revert the changes done in commit afdeaae. See further disucssion in the issue thread of #3179 starting from [2]. [1]: https://www.mediawiki.org/wiki/Manual:Page_title [2]: #3179 (comment) * Bugfix/security exception (#3627) * Fixes #3626 * Check is file is actually created before writing to file, file picker android * Handle Security exception * Fixes #3436 and #2881: Media Detail design Overhaul (#3505) * ic_map_dark_24dp: map icon for white background * ic_info_outline_dark_24dp: info icon for dark background * MediaDetailFragment: update the spacer as per image aspect ratio * fragment_media_detail: design overhaul * fragment_media_detail: remove redundant background color statements * make requested changes * add dark mode support * minor ui tweak * white map icon in dark mode * make rquested changes * make requested changes to layout * fix misalignment of category list * subtle amendments * convert comments to javadocs * minor amendments * minor changes * add styles for media detail * Media detail fragment refactored * make suggested changes * minor name fix * fix the delete button border * Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) (#3686) * Add #3723 and #3721 to 2.13 release, fix conflicts Conflicts were caused by merging #3723 before #3721 , so I just rolled both into one commit. * Fix NullPointer when clicking on image in MediaDetailFragment (#3730)… (#3739) * Update changelog.md * Versioning for v2.13 * Fixes #3705 (Crash when viewing pic I just uploaded) (#3782) * Fixes #3705 * Let the MediaDetailPager fragment know when the contributions have been updated * Handle NPE, null check on adapter in MediaDetailPagerFragment * Fixed BookmarkLocationsDao DB migration (#3793) * Fixes #3725 (#3795) * Downgraded okhttp version to support Api 19 devices * Handled null CompoundDrawable[2] in etTitle-> UploadMediaDetailsFragment (#3828) * DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (#3830) * Fixes #3829 * DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception * removed unused imports, handled possible exceptions * Let Fresco handle the downsampling of image * invalidate in onTransformEnd * Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end * removed photoView dependency * removed unused imports in ZoomableActivity * Bugfix, expand/collapse * changed functio name * Bugfix/p18 uploads (#3869) * updated gradle plugin version * BugFix #3856 * Do not use preference for deciding acceptable lat long for nearby uploads, instead save the corresponding location in the Contribution via UploadItem * Marshall contribution's hasInvalidLocation * reset un-related changes * Fixed test cases * Minor code formatting and docs * Fixes #3882 (#3883) * Make hasInvalidLocation non-null integer with default value 0 Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local> * Fixes #3766, Added OPENSTREET attribution (#3889) * Fixes #3766 * Added OPENSTREET attribution in nearby * Added custom text attribution in Nearby * Deleted unused class CustomBorderTextView * review suggested changes * modified telemetry summary string * Versioning and changelog for v2.13.1 (#3908) * Update changelog.md * Versioning for v2.13.1 * Fixes #3914 (#3915) * Verify user login before setting upload count * fixed compile-time error * fix erros * delete emptied files * remove empty file CategoriesModel.java Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Kshitij Bhardwaj <44129798+kbhardwaj123@users.noreply.github.com> Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com> Co-authored-by: Josephine Lim <josephinelim86@gmail.com> Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>

* commons-app#3624 DateTimeFormat wrong - match pattern returned from servers (commons-app#3625) * Revert "Fixes: commons-app#3179 Make category search non case-sensitive (commons-app#3326)" (commons-app#3636) Simply lower casing the name of the category sent to the server doesn't result in the server doing a case insensitive category search. In fact, it reduces the category search space as only categories that has a lower case character is searched even if the search text contains upper case characters. The test case did not catch this issue as the first character of the title is case insensitive[1]. So, revert the changes done in commit afdeaae. See further disucssion in the issue thread of commons-app#3179 starting from [2]. [1]: https://www.mediawiki.org/wiki/Manual:Page_title [2]: commons-app#3179 (comment) * Bugfix/security exception (commons-app#3627) * Fixes commons-app#3626 * Check is file is actually created before writing to file, file picker android * Handle Security exception * Fixes commons-app#3436 and commons-app#2881: Media Detail design Overhaul (commons-app#3505) * ic_map_dark_24dp: map icon for white background * ic_info_outline_dark_24dp: info icon for dark background * MediaDetailFragment: update the spacer as per image aspect ratio * fragment_media_detail: design overhaul * fragment_media_detail: remove redundant background color statements * make requested changes * add dark mode support * minor ui tweak * white map icon in dark mode * make rquested changes * make requested changes to layout * fix misalignment of category list * subtle amendments * convert comments to javadocs * minor amendments * minor changes * add styles for media detail * Media detail fragment refactored * make suggested changes * minor name fix * fix the delete button border * Fixes commons-app#3639 (Fix Save State implementation of CheckBoxTriState ) (commons-app#3686) * Add commons-app#3723 and commons-app#3721 to 2.13 release, fix conflicts Conflicts were caused by merging commons-app#3723 before commons-app#3721 , so I just rolled both into one commit. * Fix NullPointer when clicking on image in MediaDetailFragment (commons-app#3730)… (commons-app#3739) * Update changelog.md * Versioning for v2.13 * Fixes commons-app#3705 (Crash when viewing pic I just uploaded) (commons-app#3782) * Fixes commons-app#3705 * Let the MediaDetailPager fragment know when the contributions have been updated * Handle NPE, null check on adapter in MediaDetailPagerFragment * Fixed BookmarkLocationsDao DB migration (commons-app#3793) * Fixes commons-app#3725 (commons-app#3795) * Downgraded okhttp version to support Api 19 devices * Handled null CompoundDrawable[2] in etTitle-> UploadMediaDetailsFragment (commons-app#3828) * DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (commons-app#3830) * Fixes commons-app#3829 * DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception * removed unused imports, handled possible exceptions * Let Fresco handle the downsampling of image * invalidate in onTransformEnd * Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end * removed photoView dependency * removed unused imports in ZoomableActivity * Bugfix, expand/collapse * changed functio name * Bugfix/p18 uploads (commons-app#3869) * updated gradle plugin version * BugFix commons-app#3856 * Do not use preference for deciding acceptable lat long for nearby uploads, instead save the corresponding location in the Contribution via UploadItem * Marshall contribution's hasInvalidLocation * reset un-related changes * Fixed test cases * Minor code formatting and docs * Fixes commons-app#3882 (commons-app#3883) * Make hasInvalidLocation non-null integer with default value 0 Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local> * Fixes commons-app#3766, Added OPENSTREET attribution (commons-app#3889) * Fixes commons-app#3766 * Added OPENSTREET attribution in nearby * Added custom text attribution in Nearby * Deleted unused class CustomBorderTextView * review suggested changes * modified telemetry summary string * Versioning and changelog for v2.13.1 (commons-app#3908) * Update changelog.md * Versioning for v2.13.1 * Fixes commons-app#3914 (commons-app#3915) * Verify user login before setting upload count * fixed compile-time error * fix erros * delete emptied files * remove empty file CategoriesModel.java Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Kshitij Bhardwaj <44129798+kbhardwaj123@users.noreply.github.com> Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com> Co-authored-by: Josephine Lim <josephinelim86@gmail.com> Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>

Fixes commons-app#3639

31c479b

* Removed custom save state implementatio of CheckBoxTriState * Save/Restore CheckBox state in NearbyParentFragment

tests-checker bot suggested changes Apr 21, 2020

View reviewed changes

removed unused imports in CheckBoxTriStates

28f4aaa

neslihanturan approved these changes Apr 21, 2020

View reviewed changes

neslihanturan requested changes Apr 21, 2020

View reviewed changes

set CheckBoxTriState onViewStateRestored

cd3dc1c

kbhardwaj123 mentioned this pull request Apr 22, 2020

Fixes #3687 : Media needs refactoring to remove code that has been rendered useless #3693

Merged

neslihanturan approved these changes Apr 22, 2020

View reviewed changes

neslihanturan requested changes Apr 22, 2020

View reviewed changes

Set Callback for CheckBoxTriState in onViewCreated as well, it maybe …

431b2d2

…called before onViewRestored sometimes

neslihanturan approved these changes Apr 22, 2020

View reviewed changes

bug-fix restore check box state

9f0f132

donot save checkbox state

ebe2511

donot save checkbox's state in onSaveInstanceState

f0f4e18

macgills reviewed Apr 24, 2020

View reviewed changes

ashishkumar468 added 2 commits April 24, 2020 14:01

reset changes in ProjectCodeStyleConfiguration

5a9932f

reset changes in NearbyParentFragment

95507bc

misaochan requested a review from macgills April 25, 2020 10:45

neslihanturan merged commit 461249f into commons-app:2.13-release Apr 26, 2020

This was referenced May 7, 2020

Fixes #3458 "MainActivity cannot be recreated" #3497

Closed

MainActivity cannot be recreated #3458

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) #3686

Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) #3686

ashishkumar468 commented Apr 21, 2020

tests-checker bot left a comment

macgills commented Apr 21, 2020

neslihanturan left a comment

macgills commented Apr 21, 2020

neslihanturan left a comment

ashishkumar468 commented Apr 21, 2020

codecov-io commented Apr 21, 2020 •

edited

Loading

macgills commented Apr 22, 2020

neslihanturan left a comment

neslihanturan commented Apr 22, 2020

neslihanturan left a comment

ashishkumar468 commented Apr 22, 2020

neslihanturan commented Apr 22, 2020 •

edited

Loading

neslihanturan left a comment

macgills commented Apr 22, 2020

macgills commented Apr 22, 2020

ashishkumar468 commented Apr 22, 2020

ashishkumar468 commented Apr 22, 2020

macgills commented Apr 23, 2020

ashishkumar468 commented Apr 23, 2020

misaochan commented Apr 23, 2020

neslihanturan commented Apr 23, 2020

ashishkumar468 commented Apr 23, 2020 •

edited

Loading

macgills Apr 24, 2020

ashishkumar468 Apr 24, 2020

macgills Apr 24, 2020

ashishkumar468 Apr 24, 2020

macgills Apr 24, 2020

macgills Apr 24, 2020

ashishkumar468 Apr 24, 2020

neslihanturan commented Apr 26, 2020

Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) #3686

Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) #3686

Conversation

ashishkumar468 commented Apr 21, 2020

tests-checker bot left a comment

Choose a reason for hiding this comment

macgills commented Apr 21, 2020

neslihanturan left a comment

Choose a reason for hiding this comment

macgills commented Apr 21, 2020

neslihanturan left a comment

Choose a reason for hiding this comment

ashishkumar468 commented Apr 21, 2020

codecov-io commented Apr 21, 2020 • edited Loading

Codecov Report

macgills commented Apr 22, 2020

neslihanturan left a comment

Choose a reason for hiding this comment

neslihanturan commented Apr 22, 2020

neslihanturan left a comment

Choose a reason for hiding this comment

ashishkumar468 commented Apr 22, 2020

neslihanturan commented Apr 22, 2020 • edited Loading

neslihanturan left a comment

Choose a reason for hiding this comment

macgills commented Apr 22, 2020

macgills commented Apr 22, 2020

ashishkumar468 commented Apr 22, 2020

ashishkumar468 commented Apr 22, 2020

macgills commented Apr 23, 2020

ashishkumar468 commented Apr 23, 2020

misaochan commented Apr 23, 2020

neslihanturan commented Apr 23, 2020

ashishkumar468 commented Apr 23, 2020 • edited Loading

macgills Apr 24, 2020

Choose a reason for hiding this comment

ashishkumar468 Apr 24, 2020

Choose a reason for hiding this comment

macgills Apr 24, 2020

Choose a reason for hiding this comment

ashishkumar468 Apr 24, 2020

Choose a reason for hiding this comment

macgills Apr 24, 2020

Choose a reason for hiding this comment

macgills Apr 24, 2020

Choose a reason for hiding this comment

ashishkumar468 Apr 24, 2020

Choose a reason for hiding this comment

neslihanturan commented Apr 26, 2020

codecov-io commented Apr 21, 2020 •

edited

Loading

neslihanturan commented Apr 22, 2020 •

edited

Loading

ashishkumar468 commented Apr 23, 2020 •

edited

Loading