Fixes #3412 Add option to not show the dialog again #3413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
yashk2000
requested review from
nicolas-raoul,
maskaravivek,
misaochan and
neslihanturan
Codecov Report
@@ Coverage Diff @@
## master #3413 +/- ##
=========================================
- Coverage 7.75% 7.75% -0.01%
=========================================
Files 256 256
Lines 11344 11351 +7
Branches 924 925 +1
=========================================
Hits 880 880
- Misses 10397 10404 +7
Partials 67 67
Continue to review full report at Codecov.
|
|
@yashk2000 I am closing this PR for now as we haven't decided on how to tackle the approach yet. Lets first discuss it in #3413. It would be great if you could refrain from opening a issue and then simply creating a PR for it without having the issue assigned to you and without discussing the solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3412 No contributions dialog keeps popping repeatedly.
What changes did you make and why?
Added an option to not show the no contributions dialog repeatedly. Now it's up to the user to choose whether to be shown this dialog again and again or not. This improves the UX of the app. Otherwise, it gets very tiresome for a user to keep canceling this dialog every time the achievements activity is opened.
Tests performed (required)
Tested ProdDebug on Nokia 7 Plus with API level 29.