Fixes #3303 Nearby Crashes when options menu is clicked

[ashishkumar468]

Description (required)

Fixes Nearby Crashes when options menu is clicked #3303

What changes did you make and why?
Initialize bottom-sheet-behavior in onViewCreated

Tests performed (required)

Tested betaDebug on Android 9

[tests-checker]

Could you please add tests to make sure this change works as expected?

[codecov-io]

Codecov Report

Merging #3304 into 2.12-release will decrease coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           2.12-release   #3304      +/-   ##
===============================================
- Coverage          6.52%   6.52%   -0.01%     
===============================================
  Files               270     270              
  Lines             11641   11643       +2     
  Branches            909     909              
===============================================
  Hits                760     760              
- Misses            10821   10823       +2     
  Partials             60      60

Impacted Files	Coverage Δ
...commons/nearby/fragments/NearbyParentFragment.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959b3af...550c672. Read the comment docs.

[neslihanturan]

Thanks for the PR @ashishkumar468 . Even if it prevents the crash, it does not work as intended for me. I think instead of moving the line "initViews" is called, we should make sure "childMapFragmentAttached" is called after changing settings too.

[ashishkumar468]

@neslihanturan True, but I was hoping if that could be done in a separate PR. The initViews() function should have been done in the fragments onViewCreated anyways. What do you think?

[neslihanturan]

Closing this one sine the other one seems related #3322