Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3191 Make the username along with the rewards icon clickable in the Navigation Drawer #3283

Closed
wants to merge 4 commits into from
Closed

Fixes #3191 Make the username along with the rewards icon clickable in the Navigation Drawer #3283

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d48e839
Merge pull request #1 from commons-app/master
ajuancer Dec 7, 2019
14dddb4
Implementing call to AchievementsActivity.java
ajuancer Dec 7, 2019
d786d92
Implementing call to AchievementsActivity.jav
ajuancer Dec 8, 2019
3fbcf03
Making makeClickable() more generic
ajuancer Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ private void setUserName() {
drawerLayout.closeDrawer(navigationView);
AchievementsActivity.startYourself(NavigationBaseActivity.this);
});
TextView userName = navHeaderView.findViewById(R.id.username);
userName.setOnClickListener(v -> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to somehow extract the onclick listener to a method or something, so that you do not simply need to duplicate the code, but instead call a function :)

drawerLayout.closeDrawer(navigationView);
AchievementsActivity.startYourself(NavigationBaseActivity.this);
});
}

public void initBackButton() {
Expand Down