Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed beta wikidata url #3229

Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #3228 App crashes at start on current master

What changes did you make and why?
Fixed malformed WIKIDATA_URL for prod flavor

Tests performed (required)

Tested betaDebug on Pixel-2 Api 27

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves for me, thanks @ashishkumar468 :)

@codecov-io
Copy link

Codecov Report

Merging #3229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3229   +/-   ##
======================================
  Coverage    6.01%   6.01%           
======================================
  Files         270     270           
  Lines       11600   11600           
  Branches      905     905           
======================================
  Hits          698     698           
  Misses      10845   10845           
  Partials       57      57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c1184...8028f0a. Read the comment docs.

@neslihanturan neslihanturan merged commit e828797 into commons-app:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes at start on current master, beta debug
3 participants