Fix ability to make POST requests to Wikidata. #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks so much @dbrant ! :) Looks good to me, but lets wait for @maskaravivek 's review since he was the one working on it.
Oof. :( We'd need to fix this before release. Any chance you could send us logs of the crashes? What Android version are you using? |
misaochan
approved these changes
Nov 21, 2019
|
@maskaravivek has confirmed that it works for him when layered over his other changes. Thanks @dbrant !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, I've just gotten around to being able to take a look at this issue you've been having. Fortunately, the fix consists of one line of code.
The correct domain name of Wikidata is
www.wikidata.org, notwikidata.org. This matters when making authenticated POST requests.I was able to test this live in the app (see this item), by working around the other crashes that happen when uploading from Nearby.