Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With wikidata changes #3199

Merged
merged 1 commit into from
Nov 23, 2019
Merged

With wikidata changes #3199

merged 1 commit into from
Nov 23, 2019

Conversation

maskaravivek
Copy link
Member

@maskaravivek maskaravivek commented Nov 6, 2019

Fixes issue with Wikidata edits from backend overhaul.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@02f5cda). Click here to learn what that means.
The diff coverage is 8.51%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3199   +/-   ##
========================================
  Coverage          ?   6.22%           
========================================
  Files             ?     264           
  Lines             ?   11205           
  Branches          ?     851           
========================================
  Hits              ?     698           
  Misses            ?   10450           
  Partials          ?      57
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/CommonsApplication.java 0% <ø> (ø)
...a/fr/free/nrw/commons/OkHttpConnectionFactory.java 0% <ø> (ø)
...mmons/contributions/ContributionsListFragment.java 0% <ø> (ø)
...n/java/fr/free/nrw/commons/upload/UploadModel.java 23.74% <ø> (ø)
...java/fr/free/nrw/commons/upload/UploadService.java 0% <ø> (ø)
.../commons/wikidata/model/WbCreateClaimResponse.java 0% <0%> (ø)
.../java/fr/free/nrw/commons/di/NetworkingModule.java 0% <0%> (ø)
...a/fr/free/nrw/commons/wikidata/WikidataClient.java 0% <0%> (ø)
...nrw/commons/wikidata/model/AddEditTagResponse.java 0% <0%> (ø)
...a/fr/free/nrw/commons/wikidata/model/PageInfo.java 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f5cda...2adf315. Read the comment docs.

@maskaravivek maskaravivek force-pushed the wikidata-fix branch 4 times, most recently from 2bc9804 to 751d21f Compare November 23, 2019 09:15
@maskaravivek maskaravivek marked this pull request as ready for review November 23, 2019 09:15
@ashishkumar468 ashishkumar468 merged commit 891d9ec into master Nov 23, 2019
@ashishkumar468 ashishkumar468 deleted the wikidata-fix branch November 23, 2019 09:56
@ashishkumar468
Copy link
Collaborator

Tested on Pixel 2, Works fine for me, Thanks @maskaravivek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants