-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with #3129 issue #3146
Working with #3129 issue #3146
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,7 +199,7 @@ void shareScreen(Bitmap bitmap) { | |
intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | ||
intent.putExtra(Intent.EXTRA_STREAM, fileUri); | ||
intent.setType("image/png"); | ||
startActivity(Intent.createChooser(intent, "Share image via")); | ||
startActivity(Intent.createChooser(intent, getString(R.string.achiev_activity_share_screen))); | ||
} catch (IOException e) { | ||
e.printStackTrace(); | ||
} | ||
|
@@ -316,8 +316,8 @@ private void setUploadProgress(int uploadCount){ | |
|
||
private void setZeroAchievements() { | ||
AlertDialog.Builder builder=new AlertDialog.Builder(this) | ||
.setMessage("You haven't made any contributions yet") | ||
.setPositiveButton("Ok", (dialog, which) -> { | ||
.setMessage(getString(R.string.achiev_activity_set_zero_achiev)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest spelling the full word |
||
.setPositiveButton(getString(R.string.ok), (dialog, which) -> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly this could be no_achievements_yet There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am sorry I meant, "no_achievements_yet" :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say no_achievements_yet is grammatically better? :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, my bad, the same typo again, @PavelAplevich would be great if you could make it "no_achievements_yet" |
||
}); | ||
AlertDialog dialog = builder.create(); | ||
dialog.show(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
import android.widget.Toast; | ||
|
||
import fr.free.nrw.commons.BuildConfig; | ||
import fr.free.nrw.commons.R; | ||
import fr.free.nrw.commons.theme.BaseActivity; | ||
import timber.log.Timber; | ||
|
||
|
@@ -39,7 +40,7 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) { | |
Timber.d("Overriding URL %s", url); | ||
|
||
Toast toast = Toast.makeText(SignupActivity.this, | ||
"Account created!", Toast.LENGTH_LONG); | ||
R.string.sign_up_activity_account, Toast.LENGTH_LONG); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. account_created |
||
toast.show(); | ||
// terminate on task completion. | ||
finish(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be made generic, share_image_via