Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth issues in the app #3064

Merged

Conversation

maskaravivek
Copy link
Member

@maskaravivek maskaravivek commented Jul 11, 2019

Partial fix for #3026 (comment)

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@maskaravivek maskaravivek changed the title Fix auth issues in the app [WIP] Fix auth issues in the app Jul 11, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (backend-overhaul@5d64cac). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             backend-overhaul   #3064   +/-   ##
==================================================
  Coverage                    ?   5.35%           
==================================================
  Files                       ?     268           
  Lines                       ?   11797           
  Branches                    ?     960           
==================================================
  Hits                        ?     632           
  Misses                      ?   11114           
  Partials                    ?      51
Impacted Files Coverage Δ
...ommons/modifications/ModificationsSyncAdapter.java 0% <ø> (ø)
...e/nrw/commons/category/CategoryImagesActivity.java 0% <ø> (ø)
...r/free/nrw/commons/auth/AuthenticatedActivity.java 0% <ø> (ø)
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0% <0%> (ø)
...r/free/nrw/commons/contributions/MainActivity.java 0% <0%> (ø)
.../java/fr/free/nrw/commons/auth/SessionManager.java 0% <0%> (ø)
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø)
...w/commons/contributions/ContributionsFragment.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d64cac...ee47a7d. Read the comment docs.

@maskaravivek maskaravivek changed the title [WIP] Fix auth issues in the app Fix auth issues in the app Jul 11, 2019
@maskaravivek maskaravivek merged commit cd57552 into commons-app:backend-overhaul Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants