-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 5 update #3023
Gradle 5 update #3023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ A review job has been created and sent to the PullRequest network.
@domdomegg you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## master #3023 +/- ##
========================================
Coverage ? 4.43%
========================================
Files ? 259
Lines ? 12261
Branches ? 1051
========================================
Hits ? 544
Misses ? 11678
Partials ? 39 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me based on this thread:
If the build fails after merging this PR, feel free to revert the change. :) |
Yay, build passed. Hopefully should get the alpha update on Google Play soon. |
Description (required)
Fixes #2824, and #3018
What changes did you make and why?
Tests performed (required)