Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 5 update #3023

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Gradle 5 update #3023

merged 2 commits into from
Jun 17, 2019

Conversation

domdomegg
Copy link
Member

Description (required)

Fixes #2824, and #3018

What changes did you make and why?

Tests performed (required)

  • Tested app on API 28
  • Tested that gradle play publisher looks like it should work (not 100% sure as not really able to replicate the setup - can revert if causes issues again but think it should be fine this time)

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@domdomegg you can click here to see the review status or cancel the code review job.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f2a499e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3023   +/-   ##
========================================
  Coverage          ?   4.43%           
========================================
  Files             ?     259           
  Lines             ?   12261           
  Branches          ?    1051           
========================================
  Hits              ?     544           
  Misses            ?   11678           
  Partials          ?      39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a499e...250b355. Read the comment docs.

Copy link
Member

@maskaravivek maskaravivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on this thread:

Triple-T/gradle-play-publisher#451

@maskaravivek
Copy link
Member

If the build fails after merging this PR, feel free to revert the change. :)

@maskaravivek maskaravivek merged commit 8e35787 into commons-app:master Jun 17, 2019
@domdomegg
Copy link
Member Author

Yay, build passed. Hopefully should get the alpha update on Google Play soon.

@domdomegg domdomegg deleted the gradle-5-update branch June 17, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Gradle 5
3 participants