-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/uploads #3002
Merged
maskaravivek
merged 15 commits into
commons-app:refactor_uploads
from
ashishkumar468:bugfix/uploads
Jun 10, 2019
Merged
Bugfix/uploads #3002
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4e1cbba
merged with master
ashishkumar468 aa86057
BugFix IllegalStateException
ashishkumar468 b7685d5
BugFix, clear selected categoris for previous upload session
ashishkumar468 c8985bd
Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/Uploa…
ashishkumar468 bce2b78
Added class level JavaDoc UploadRemoteDataSource
ashishkumar468 1eb2bc6
Added class level JavaDoc for UploadRepository
ashishkumar468 196c27c
Added JavaDocs for ThumbnailsAdapter
ashishkumar468 f239425
Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
ashishkumar468 2e33ef7
Removed null check on category query
ashishkumar468 9cde838
Attached image scale listener to upload media image
ashishkumar468 185b0e4
Bug fix, reduced the add description edit text clickable bound
ashishkumar468 27d768b
Added tooltip in Title in UploadMediaFragment
ashishkumar468 1c2eb07
BugFix recent categories
ashishkumar468 7d717ea
Updated test methods
ashishkumar468 28ed254
resolved merge conflictas
ashishkumar468 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the category suggestion should be shown even if query text is not empty