Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Robolectric 4 #2982

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Upgrade to Robolectric 4 #2982

merged 1 commit into from
Jun 4, 2019

Conversation

domdomegg
Copy link
Member

@domdomegg domdomegg commented Jun 2, 2019

Description (required)

Upgrade to Roboelectric 4. This is so we can upgrade Gradle and various other components so the app is more stable and we can get instrumentation tests working again (#2868).

What changes did you make and why?

Tests performed (required)

Tested betaDebug on API level 28
All unit tests pass

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@domdomegg you can click here to see the review status or cancel the code review job.

@codecov-io
Copy link

Codecov Report

Merging #2982 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2982   +/-   ##
======================================
  Coverage    3.69%   3.69%           
======================================
  Files         247     247           
  Lines       12213   12213           
  Branches     1081    1081           
======================================
  Hits          451     451           
  Misses      11728   11728           
  Partials       34      34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12883e3...156f584. Read the comment docs.

@maskaravivek maskaravivek merged commit 67e43ef into commons-app:master Jun 4, 2019
@domdomegg domdomegg deleted the robolectric-4 branch June 13, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants