-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified scroll behaviour of review activity #2732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
======================================
Coverage 2.72% 2.72%
======================================
Files 267 267
Lines 12801 12801
Branches 1137 1137
======================================
Hits 349 349
Misses 12426 12426
Partials 26 26 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android:layout_height="25dp" | ||
android:background="@android:color/transparent" | ||
android:layout_below="@+id/toolbar" | ||
android:text="SKIP THIS IMAGE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it wasn't previously, but it should use a @string
resource rather than hardcoded text.
@domdomegg before #2709 there was scrolling of whole activity including of image, I removed whole activity scrolling in that PR . In this current PR i adjusted the views to avoid scrolling every now and then. But it may scroll when occupies more than the extra space allotted. So should I revert the changes in scrolling that I did in #2709 ? |
Sorry, I mean the whole activity should scroll up and down, and only the questions should scroll sideways - if that makes sense. |
Yes that's what happens previously. I'll revert the changes and send another PR 👍 |
Before your previous PR (f7e6b20) this is what used to happen: The whole activity scrolls up and down, and the whole activity scrolls sideways After your PR, only the bottom bit scrolls up and down, and only the bottom bit scrolls sideways I meant to change it so that the whole activity scrolls up and down, and only the bottom bit scrolls sideways. |
@domdomegg I have made the changes. Kindly review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2.10.1-debug-peer_scroll~bf826ad6d
Thanks for approving the PR @domdomegg :) |
Description (required)
Fixes sub-task of #2698 [Scrolling behaviour of Review Activity]
Changes made
Modified activity_review.xml and fragment_review_image.xml
Screenshot