modified scroll behaviour of review activity

[vanshikaarora]

Description (required)
Fixes sub-task of #2698 [Scrolling behaviour of Review Activity]

Changes made

Modified activity_review.xml and fragment_review_image.xml

Screenshot

[codecov-io]

Codecov Report

Merging #2732 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2732   +/-   ##
======================================
  Coverage    2.72%   2.72%           
======================================
  Files         267     267           
  Lines       12801   12801           
  Branches     1137    1137           
======================================
  Hits          349     349           
  Misses      12426   12426           
  Partials       26      26

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbab7dd...bf826ad. Read the comment docs.

[domdomegg]

I think it might be better if the whole page scrolled part from 'skip this image'. Currently just the bottom bit does.

Also we want to fix hardcoded text - see code comment

[domdomegg]

I know it wasn't previously, but it should use a @string resource rather than hardcoded text.

[vanshikaarora]

I think it might be better if the whole page scrolled part from 'skip this image'. Currently just the bottom bit does.

@domdomegg before #2709 there was scrolling of whole activity including of image, I removed whole activity scrolling in that PR .

In this current PR i adjusted the views to avoid scrolling every now and then. But it may scroll when occupies more than the extra space allotted.

So should I revert the changes in scrolling that I did in #2709 ?

[domdomegg]

Sorry, I mean the whole activity should scroll up and down, and only the questions should scroll sideways - if that makes sense.

[vanshikaarora]

I mean the whole activity should scroll up and down

Yes that's what happens previously. I'll revert the changes and send another PR 👍

[domdomegg]

Before your previous PR (f7e6b20) this is what used to happen:

The whole activity scrolls up and down, and the whole activity scrolls sideways

After your PR, only the bottom bit scrolls up and down, and only the bottom bit scrolls sideways

I meant to change it so that the whole activity scrolls up and down, and only the bottom bit scrolls sideways.

[vanshikaarora]

@domdomegg I have made the changes. Kindly review :)

[domdomegg]

Tested 2.10.1-debug-peer_scroll~bf826ad6d

Beta Commons Upload

[vanshikaarora]

Thanks for approving the PR @domdomegg :)