-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update min sdk version and remove redundant checks #2608
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
=========================================
+ Coverage 2.69% 2.69% +<.01%
=========================================
Files 258 258
Lines 12318 12303 -15
Branches 1117 1110 -7
=========================================
Hits 332 332
+ Misses 11960 11945 -15
Partials 26 26
Continue to review full report at Codecov.
|
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
isActivityDestroyed = activity.isDestroyed(); | ||
} | ||
boolean isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable probably not necessary after refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this. The corresponding function is not getting used. Should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - let's do it in another PR
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
isActivityDestroyed = activity.isDestroyed(); | ||
} | ||
isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable probably not necessary after refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domdomegg This function is not getting used anywhere in the codebase. Is it fine if I remove the whole function altogether? Or should that be done in another PR?
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
isActivityDestroyed = activity.isDestroyed(); | ||
} | ||
isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable probably not necessary after refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2.10.1-debug-minSdk~43c5f8550
Description (required)
Fixes #1131
What changes did you make and why?
Tests performed (required)
built and ran the
betaDebug
variant of the app. It seems to be working fine.