Update min sdk version and remove redundant checks #2608
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
=========================================
+ Coverage 2.69% 2.69% +<.01%
=========================================
Files 258 258
Lines 12318 12303 -15
Branches 1117 1110 -7
=========================================
Hits 332 332
+ Misses 11960 11945 -15
Partials 26 26
Continue to review full report at Codecov.
|
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
| isActivityDestroyed = activity.isDestroyed(); | ||
| } | ||
| boolean isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
This variable probably not necessary after refactor
There was a problem hiding this comment.
Same for this. The corresponding function is not getting used. Should it be removed?
There was a problem hiding this comment.
Yeah - let's do it in another PR
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
| isActivityDestroyed = activity.isDestroyed(); | ||
| } | ||
| isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
This variable probably not necessary after refactor
There was a problem hiding this comment.
@domdomegg This function is not getting used anywhere in the codebase. Is it fine if I remove the whole function altogether? Or should that be done in another PR?
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
| isActivityDestroyed = activity.isDestroyed(); | ||
| } | ||
| isActivityDestroyed = activity.isDestroyed(); |
There was a problem hiding this comment.
This variable probably not necessary after refactor
Description (required)
Fixes #1131
What changes did you make and why?
Tests performed (required)
built and ran the
betaDebugvariant of the app. It seems to be working fine.