-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label wraps in Achievements #2577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2577 +/- ##
======================================
Coverage 5.91% 5.91%
======================================
Files 258 258
Lines 12324 12324
Branches 1114 1114
======================================
Hits 729 729
Misses 11536 11536
Partials 59 59
Continue to review full report at Codecov.
|
Looks great! |
@nicolas-raoul |
Would you mind trying to make it right-aligned in RTL mode? And if it works, would you mind applying the same technique to "featured images" and "thanks received" too? While not long in English, there might be languages where the they are much longer and fill the line on very small screens. Thanks a lot! :-) |
Hello @nicolas-raoul, Made the text right-aligned in RTL layout and applied the same technique to "featured images" and "thanks received". Screenshots For short text
For long text
Thank you! |
Looks perfect! :-) |
**Description **
Label wraps number in Achievements
Fixes #2465 Label overlaps number in Achievements
What changes did you make and why?
Align TextView with toStartOf in a RelativeLayout in order to avoid overlapping.
Tests performed
Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 27.
Screenshot