Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label wraps in Achievements #2577

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Conversation

silkypriya
Copy link
Contributor

**Description **
Label wraps number in Achievements

Fixes #2465 Label overlaps number in Achievements

What changes did you make and why?

Align TextView with toStartOf in a RelativeLayout in order to avoid overlapping.

Tests performed

Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 27.

Screenshot

54423260_1153996374780011_5261934081242824704_n

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #2577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2577   +/-   ##
======================================
  Coverage    5.91%   5.91%           
======================================
  Files         258     258           
  Lines       12324   12324           
  Branches     1114    1114           
======================================
  Hits          729     729           
  Misses      11536   11536           
  Partials       59      59
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/upload/UploadPresenter.java 10.92% <0%> (-0.07%) ⬇️
...java/fr/free/nrw/commons/upload/UploadService.java 0% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/delete/DeleteTask.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d03274...b730b51. Read the comment docs.

@silkypriya silkypriya changed the title Label wraps number in Achievements Label wraps in Achievements Mar 12, 2019
@nicolas-raoul
Copy link
Member

Looks great!
Would you mind checking in right-to-left locale too?
Thank you :-)

@silkypriya
Copy link
Contributor Author

@nicolas-raoul
Result in forced right-to-left layout
54190704_2392563594135947_1293385085717839872_n

@nicolas-raoul
Copy link
Member

Would you mind trying to make it right-aligned in RTL mode?

And if it works, would you mind applying the same technique to "featured images" and "thanks received" too? While not long in English, there might be languages where the they are much longer and fill the line on very small screens.

Thanks a lot! :-)

@silkypriya
Copy link
Contributor Author

silkypriya commented Mar 13, 2019

Hello @nicolas-raoul,

Made the text right-aligned in RTL layout and applied the same technique to "featured images" and "thanks received".

Screenshots

For short text

Left to Right Mode Right to Left Mode
s rtl s

For long text

Left to Right Mode Right to Left Mode
l rtl l

Thank you!

@nicolas-raoul
Copy link
Member

Looks perfect! :-)

@maskaravivek maskaravivek merged commit 5038876 into commons-app:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants