Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up gradle.properties #2175

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Tidy up gradle.properties #2175

merged 1 commit into from
Jan 27, 2019

Conversation

domdomegg
Copy link
Member

Description (required)

Working towards fixing #1941, and generally improving code quality

Low priority, however I don't think these lines of these files will cause merge conflicts with any other PRs.

What changes did you make and why?

  • Tidied up gradle.properties by grouping related properties
  • Moved Kotlin version property from build.gradle to gradle.properties like all the other version properties
  • Renamed some version properties so they are all consistently PACKAGE_NAME_VERSION

Did not change any versions in this PR so should be functionally identical

Tests performed (required)

All unit tests pass

Tested 2.9.0-debug-tidy-gradle-props~911bda1b4 (betaDebug) on Galaxy Nexus (emulator) with API level 28.

@codecov-io
Copy link

Codecov Report

Merging #2175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2175   +/-   ##
======================================
  Coverage    5.69%   5.69%           
======================================
  Files         233     233           
  Lines       11639   11639           
  Branches     1082    1082           
======================================
  Hits          663     663           
  Misses      10921   10921           
  Partials       55      55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a58454...911bda1. Read the comment docs.

@maskaravivek
Copy link
Member

A few people are having trouble with fresh clones. Am merging this to put it out for alpha users while #2289 gets merge ready.

@maskaravivek maskaravivek merged commit 67c5d20 into commons-app:master Jan 27, 2019
@domdomegg domdomegg deleted the tidy-gradle-props branch March 15, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants