Sweeping update of gradle and dependency versions. #1858
Conversation
This updates all of the dependencies of the project to their latest versions. Everyone should please upgrade to the latest version of Android Studio, update your build tools, and keep your version of Gradle and the Kotlin plugin up to date.
.travis.yml
Outdated
| script: | ||
| - ./gradlew clean check connectedCheck jacocoTestReport |
There was a problem hiding this comment.
I believe this change removes connected tests (tests under app/src/androitTests) and code coverage checks from Travis build scripts. Why do they have to go?
There was a problem hiding this comment.
@whym whoops, I've put this back in the subsequent commits. I think I must have removed this while getting stuff working locally.
|
Note to the person testing this: Please make sure that you give the app a thorough overall test on the ProdRelease build variant, as we have had issues with library and gradle updates causing issues in Release builds that wasn't apparent on Debug builds. |
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
=========================================
+ Coverage 3.69% 3.7% +<.01%
=========================================
Files 191 191
Lines 9876 9882 +6
Branches 885 885
=========================================
+ Hits 365 366 +1
- Misses 9484 9489 +5
Partials 27 27
Continue to review full report at Codecov.
|
String literals are being used in many places in the code, instead of proper string resources which are automatically localized. This PR replaces many of the string literals with pre-packaged resources, or will add the appropriate string if necessary.
…p#1849) * Add button on image details to copy wikicode to clipboard * Make copy wikicode button width the same as the nominate deletion button width by filling in background
|
It looks like something is pushing the app beyond the dex limit again... |
This enables ProGuard minification, which significantly shrinks the APK (for both debug and release configurations) and vastly decreases the method count.
|
Ready! Note to reviewers: this will now introduce Proguard (for minifying only, not obfuscating) for all builds, including debug, release, and test. This should not have any adverse effects, but there might be an infinitesimal possibility of compile-time or runtime errors if something goes wrong in one or more dependencies. Note that this also greatly reduces your method count, which will now be a healthy ~45000, allowing you to add dozens more custom libraries if you like 😉. |
|
Thanks for fixing the conflicts, @dbrant ! AFAIK, we disabled Proguard minify due to this issue: https://stackoverflow.com/questions/40232404/google-play-apk-and-android-studio-apk-usb-debug-behaving-differently . Basically, location-based category suggestions were not working on Release builds when we had minify enabled. However, that code has been refactored significantly since then, so I'm all good with having minify back, as long as location-based category suggestions are tested successfully on a Release build variant. :) @neslihanturan do you think you could do this? Build a prodRelease build, upload a geotagged image for a well-known location, and see if appropriate category suggestions are given? |
|
@dbrant thank you! Category suggestion works on prodRelease, so I merge this PR. |
This updates all of the dependencies of the project to their latest versions. Everyone should please upgrade to the latest version of Android Studio, update your build tools, and keep your version of Gradle and the Kotlin plugin up to date.