Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1406 - Error messages in LoginActivity disappear after orientation change. #1407

Merged
merged 4 commits into from
Apr 30, 2018

Conversation

knight-shade
Copy link
Contributor

Description

Fixes #1406

Now the error messages in LoginActivity persist after orientation change.

Tests performed

Tested on API level 19 & 24 & on MIUI Note 4 , with build variant BetaDebug.

Screenshots showing what changed

Before
before

After
after

@knight-shade knight-shade changed the title Fixes #1406 Error messages in LoginActivity disappear after orientation change. Fixes #1406 - Error messages in LoginActivity disappear after orientation change. Apr 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #1407 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1407      +/-   ##
=========================================
- Coverage     3.3%    3.3%   -0.01%     
=========================================
  Files         128     128              
  Lines        6837    6847      +10     
  Branches      669     671       +2     
=========================================
  Hits          226     226              
- Misses       6596    6606      +10     
  Partials       15      15
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23f752...1e37cb6. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Thanks @knight-shade this works

@neslihanturan neslihanturan merged commit 0223c5a into commons-app:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants