Fix nearby current location marker #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neslihanturan
changed the title
9 tasks
|
Haha, I hadn't even noticed this bug til you mentioned it. Great job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1329 number 8, issue Fix current location point visibility when bottom sheet is expanded, and re-center button is clicked.
Currently recenter button works correctly when bottom sheet is expanded. User can set a zoom level and use map with this zoom level. However, this is not possible when bottom sheet is expanded (zoom level is fixed to 11) , I couldn't find an easy way to do it. Besides, as a user I close bottom sheet while following map, so there is no case when I want to zoom in/out if bottom sheet is expanded.
Tests performed
Manual test API 19
![Uploading zoom.gif…]()
Screenshots showing what changed