-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app shortcut created #1313
app shortcut created #1313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
======================================
Coverage 3.82% 3.82%
======================================
Files 125 125
Lines 5902 5902
Branches 582 582
======================================
Hits 226 226
Misses 5661 5661
Partials 15 15 Continue to review full report at Codecov.
|
I did a very quick smoke test -
Installed into an emulator
And I cant launch any of the three shortcuts - for instance,
|
@psh I have fixed it. I forgot to add applicationIdSuffix for debug. |
Starting the application from a clean install, with the app logged out, I am able to select all three options from the shortcut menu and it launches directly into those activities. After entering the app using one of these shortcuts, when I select "Home" on the navigation drawer, the app crashes
This is actually a huge problem. What's happening is that the shortcuts are bypassing the login process and jumping directly into the app. If I am logged out I shouldn't be able to do that. Basically, if I select "Nearby" from the app shortcut and I am logged out, I should stop at the login screen. If I am allowed further into the app things go badly wrong. Secondly, although you solved the
There will need to be different configuration files for the |
Second one can be easily solved by adding another intent specific for release version for each shortcut. |
@psh plz give me reviews on the above idea, so i can go ahead with development. |
@tanvidadu Do you still need any help in resolving the above issues? It would be great if you could bring this PR to completion. :) |
A lot of changes needs to be made, depending upon whether the user is logged in or not :) |
Awesome, thanks. Closing this PR then. :) |
Description
Fixes #814
Added app static app shortcuts for activities Nearby, Settings and Notifications .
Tests performed
Tested on API 26 ( oreo ) with build variant betaDebug.
Screenshots showing what changed