-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1139: Nominate uploaded image for deletion #1297
Conversation
Sounds reasonable, judging from the screenshots :-) |
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
=========================================
- Coverage 3.81% 3.73% -0.09%
=========================================
Files 126 127 +1
Lines 5919 6054 +135
Branches 583 588 +5
=========================================
Hits 226 226
- Misses 5678 5813 +135
Partials 15 15
Continue to review full report at Codecov.
|
@diddypod Thanks for this great job. I think we should display "Succesfully nominated" message in more visible way, ie. with an alert. |
There is a notification for nomination process, so maybe we can recognize if an image is nominated for deletion. |
Okay @neslihanturan, I'll incorporate a check for that ASAP. |
Fixes issue: Potential multiple nominationsThe AsyncTask now checks if the Commons:Deleion_Requests subpage exists to verify if the file has previously been nominated for deletion, and proceeds accordingly. Thus, each file may be nominated for deletion only once. |
Great @diddypod , very good job:) Will be testing this immediately |
@diddypod it works quite nice, thanks for your contribution. Maybe we can notify the user about "already nominated issue" before entering the message second time. What do you say? But this can be a seperate PR, merging this one. |
Description
Fixes #1139 Add Option to delete the uploaded image.
Added DeleteTask and added new functions to MediaWikiApi to make edits to the pages
Tests performed
Tested on Xiaomi (Wingtech) Redmi 2, with betaDebug.
Screenshots showing what changed