[Bug]: explore map do not refresh automatically after enabling location services .

[Salehcodes]

Summary

Explore → Map does not automatically refresh and show places images in location after enabling location services from system settings

Steps to reproduce

1.Make sure location services are turned OFF on the device

2.Open the Commons app

3.Navigate to Explore → Map

4.A dialog appears asking to turn on location services

5.Tap Settings and enable location services

6.Return to the app

Expected behaviour

After returning from system settings with location services enabled, the map should:

Automatically recenter to the user’s current location

Load and display nearby media without requiring further user interaction

Actual behaviour

After returning from system settings:

The map does not refresh automatically

Nearby media is not loaded

The user must press the GPS logo button

Device name

Samsung Galaxy s23

Android version

Android 16

Commons app version

6.2.1

Device logs

No response

Screenshots

Screen_Recording_20260102_213313_Settings.mp4

Would you like to work on the issue?

Prefer not

[Inuth0603]

Hi, I would like to work on this issue. I have already prepared a fix for it. Could you please assign it to me?

[rohit9625]

I've assigned you. But, please don't skip this step from next time :)

[Inuth0603]

I've assigned you. But, please don't skip this step from next time :)

Noted, I will keep that in mind for future contributions. Thanks for assigning me!

[RitikaPahwa4444]

I'm not sure if it's a bug or a feature. Users use the GPS logo icon to move the map to their locations, but otherwise we use the default location. We still ask for location permissions because we need them for a map to work as intended, especially that GPS logo icon.

Does this make that icon almost redundant? The only use case I see then is when the user navigates to a different location and wants to return to their own location. Or should we ask for permissions only when the user taps that icon?

Any insights on how the community perceives this?

[Inuth0603]

I'm not sure if it's a bug or a feature. Users use the GPS logo icon to move the map to their locations, but otherwise we use the default location. We still ask for location permissions because we need them for a map to work as intended, especially that GPS logo icon.

Does this make that icon almost redundant? The only use case I see then is when the user navigates to a different location and wants to return to their own location. Or should we ask for permissions only when the user taps that icon?

Any insights on how the community perceives this?

Hi @RitikaPahwa4444!

Great question about the UX here. I've updated the PR to address the concern about making the GPS icon redundant.

My implementation:
The fix now tracks permission state across the pause/resume lifecycle. The map only auto-refreshes when permissions change from denied to granted - not every time the app resumes. This means:

✅ When user grants permission from settings: Map auto-centers (solves the bug)
✅ When user returns to app with permissions already granted: No auto-refresh (GPS button remains useful)
✅ GPS button still serves its purpose: Users can manually recenter when they navigate away and want to return to their location

Regarding the lazy permission request suggestion:
I think requesting permissions only when the GPS button is tapped is a great idea for better UX and privacy! However, that would be a larger architectural change affecting the entire permission flow. Would you prefer I:

1. Keep this PR focused on fixing the immediate bug (auto-refresh after granting permissions)
2. Open a separate issue/PR for the lazy permission request feature

Happy to implement whichever approach you think is best for the project! 😊

[nicolas-raoul]

The only use case I see then is when the user navigates to a different location and wants to return to their own location.

Yes that's a common use case. Checking what pictures have already been taken around me, I zoom in on a place a kilometer away that has a group of pictures, then want to come back to my current place to check other groups of pictures that are also close to me.

Or should we ask for permissions only when the user taps that icon?

It makes sense to show around the user's location by default. The merit of being a mobile app is that we have good location ability, that's an area the app should use to offer a distinctive experience compared to the Commons website.

[Inuth0603]

The only use case I see then is when the user navigates to a different location and wants to return to their own location.

Yes that's a common use case. Checking what pictures have already been taken around me, I zoom in on a place a kilometer away that has a group of pictures, then want to come back to my current place to check other groups of pictures that are also close to me.

Or should we ask for permissions only when the user taps that icon?

It makes sense to show around the user's location by default. The merit of being a mobile app is that we have good location ability, that's an area the app should use to offer a distinctive experience compared to the Commons website.

@nicolas-raoul Thanks for the feedback! You make an excellent point about the GPS button's use case.

I agree that showing the user's location by default makes sense for a mobile app - it leverages one of the key advantages of mobile over web. My current implementation supports this:

✅ First time opening Explore map: If permissions are granted, the map centers on user location
✅ Returning from granting permissions: Map auto-centers (fixes the bug)
✅ GPS button remains useful: When users navigate away (like your example of zooming into a different area to check pictures), they can tap the GPS button to return to their current location

So the current flow aligns with your suggestion - we use location by default, and the GPS button serves as a "return to my location" feature when users have explored other areas.

The permission state tracking in my PR just ensures that when users come back from Settings after granting permission, the map refreshes automatically without requiring an extra tap. This feels more natural since they explicitly went to Settings because the app asked them to.

Does this approach sound good to you? 😊

[RitikaPahwa4444]

Thank you @nicolas-raoul for the input. I'll start testing the PR 🙂

[Inuth0603]

Thank you @nicolas-raoul for the input. I'll start testing the PR 🙂

Thank you @RitikaPahwa4444! Looking forward to your feedback on the testing. Let me know if you find any issues or have suggestions for improvements. 😊