Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the custom picture selector the default #5812

Open
nicolas-raoul opened this issue Sep 3, 2024 · 4 comments
Open

Make the custom picture selector the default #5812

nicolas-raoul opened this issue Sep 3, 2024 · 4 comments

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Sep 3, 2024

Context

Currently, when tapping + in the main activity, there are 3 options: camera, system picker, custom picker.

It is almost impossible for new users to figure out whether they should tap system picker or custom picker.
They may try the former, be content with it, and never discover the many advantages of the custom picker.

Solution

When tapping + in the main activity, only camera and the custom picker would be available.

Only the system picker has the option to upload from Google Drive/etc, so some users may prefer it.
So we should:

  • Add a "Switch to system selector" in the hamburger menu of the custom picker. Tapping it also shows a snack or toast "You can choose the selector in the settings."
  • Add an option "Use custom picker" in the app's settings, enabled by default, just above "Use document based photo picker".
@Maykur
Copy link

Maykur commented Sep 5, 2024

Can I try taking this on? I have a few ideas on making it work!

@ErenratZeng
Copy link
Contributor

Can I quickly implement this and get the issue assign to me? Caz seems Maykur did not done this for a month.

@nicolas-raoul
Copy link
Member Author

@Maykur Anything progress or insights/findings to share? :-)

@nicolas-raoul
Copy link
Member Author

Warning: Actually recently the custom selector currently has some bugs, so even if this pull request is created, we might not merge it before a few month. So it might be better to go for a different issue. Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants