Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nearby: "Refresh" button to clear the cache and reload the Nearby map #5806

Closed
nicolas-raoul opened this issue Sep 3, 2024 · 4 comments · Fixed by #5891
Closed

Nearby: "Refresh" button to clear the cache and reload the Nearby map #5806

nicolas-raoul opened this issue Sep 3, 2024 · 4 comments · Fixed by #5891
Assignees
@noahvendrig
Labels
enhancement good first issue nearby

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Sep 3, 2024 •
edited
Loading

It would be good to have a "Refresh" icon button in the title bar of Nearby.
Tapping on it would:

  1. Empty the Nearby local cache. Context: Pins are saved in a cache so that Nearby loads faster. Even if another user adds a picture for that pin, the pin does not change color.
  2. Reload the Nearby map. It would not strictly necessary if all things were perfect, but Nearby is a fast-moving feature which often (always?) has some bugs, so I very often find myself restarting the app just to reload this map (for instance because the blue dot does not follow me).
@nicolas-raoul nicolas-raoul mentioned this issue Sep 3, 2024
Open
@OpenGreenStreet
Copy link

From my point of view, this function would be extremely helpful in many cases

@noahvendrig
Copy link
Contributor

Hi, I'm looking to solve this issue. Could you please assign me?

@kanahia1
Copy link
Contributor

kanahia1 commented Oct 6, 2024

Hi @noahvendrig, I had worked on the implementation of the caching, incase you need any help/information to it you can message me on the Zulip :)

@nicolas-raoul nicolas-raoul mentioned this issue Oct 16, 2024
Closed
@noahvendrig noahvendrig mentioned this issue Oct 25, 2024
Merged
nicolas-raoul pushed a commit that referenced this issue Oct 25, 2024
@noahvendrig @MarcusBarta
Fixes #5806 Implemented "Refresh" button to clear the cache and reloa…
3e020ed 
…d the Nearby map (#5891)

* Changed files required to get the app to run correctly. Removed suspend from affected DAO files and funcs, and changed to (Kotlin v1.9.22) and (Kotlin compiler v1.5.8)

* Created refresh button icon, and added it to the nearby_fragment_menu.xml (header of the nearby page). Created function refresh() in NearbyParentFragment.java to handle refresh functionality.

* Replaced refresh() func with emptyCache() and reloadMap()

* Attempt at reloadMap(), no testing done yet.

* added changes for a possibly working emptyCache implementation (needs testing).

* Tested changes as working, edited emptyCache to correctly clear cache and then reload map

---------

Co-authored-by: MarcusBarta <marcusbarta@icloud.com>
@OpenGreenStreet
Copy link

Thank you for the implementation. I am looking forward to the implementation . . .
When and with which version number will this be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahvendrig noahvendrig

Labels
enhancement good first issue nearby
Projects
None yet
Milestone
No milestone
4 participants
@nicolas-raoul @noahvendrig @OpenGreenStreet @kanahia1