Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Remove Telemetry due to app's privacy policy #5154

Closed
kartikaykaushik14 opened this issue Feb 24, 2023 · 8 comments · Fixed by #5155
Closed

[Bug]: Remove Telemetry due to app's privacy policy #5154

kartikaykaushik14 opened this issue Feb 24, 2023 · 8 comments · Fixed by #5155
Assignees
Labels

Comments

@kartikaykaushik14
Copy link
Contributor

kartikaykaushik14 commented Feb 24, 2023

Summary

Telemetry is often used to monitor the performance of applications, track usage patterns, and gather other data that can help developers improve their products. This data can be used to identify and diagnose issues, track trends, and make informed decisions about product development. However, due to the app's privacy, we would want to remove Telemetry from the app.

The issue is created as advised in this comment.

Steps to reproduce

  1. Have the app open
  2. Go to More
  3. Go to settings
  4. Under the Privacy section, see Mapbox Telemetry

Expected behaviour

There should be no trace of telemetry in the code and app.

Actual behaviour

As of now, the users have an option to opt-in or out of telemetry but we want it to be removed. Currently, there are traces of telemetry in the code.

Device name

Pixel 6

Android version

Android 33

Commons app version

4.0.3

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Yes

@kartikaykaushik14
Copy link
Contributor Author

@nicolas-raoul Could you please assign this issue to me?

kartikaykaushik14 added a commit to kartikaykaushik14/apps-android-commons that referenced this issue Feb 24, 2023
@kartikaykaushik14
Copy link
Contributor Author

@nicolas-raoul Could you please review the code changes?

kartikaykaushik14 added a commit to kartikaykaushik14/apps-android-commons that referenced this issue Feb 26, 2023
kartikaykaushik14 added a commit to kartikaykaushik14/apps-android-commons that referenced this issue Feb 26, 2023
kartikaykaushik14 added a commit to kartikaykaushik14/apps-android-commons that referenced this issue Feb 27, 2023
kartikaykaushik14 added a commit to kartikaykaushik14/apps-android-commons that referenced this issue Feb 27, 2023
@sivaraam
Copy link
Member

sivaraam commented Mar 15, 2023

I too wish we had the liberty to completely disable telemetry but AFAIK we need to provide the same due to requirements by Mapbox [ref]:

Additionally, you must provide a telemetry opt-out option elsewhere in your application if you choose not to use the built-in information button.

See also: #3946 (comment)

So, we might need to revisit this issue.

@sivaraam sivaraam reopened this Mar 15, 2023
@nicolas-raoul
Copy link
Member

I would argue that we comply with this documentation, as simply installing the app already opts the user out of telemetry. My understanding is of this rule's spirit is that users should not be forced to send telemetry if they do not want to.

@kartikaykaushik14 Do you know MapLibre's stance on this? Would switching to MapLibre (or another equivalent) avoid the telemetry question entirely?

@kartikaykaushik14
Copy link
Contributor Author

MapLibre seems to have removed telemetry entirely.
Sources - Link 1, Link 2, Link 3

@sivaraam
Copy link
Member

I would argue that we comply with this documentation, as simply installing the app already opts the user out of telemetry. My understanding is of this rule's spirit is that users should not be forced to send telemetry if they do not want to.

Indeed. My concern is we're not even giving the option to opt-in if at all someone wants to do that. We're just disabling it ourselves for all our users.

MapLibre seems to have removed telemetry entirely. Sources - Link 1, Link 2, Link 3

That's wonderful! If switching to it is a feasible thing and suits us well, I'm all for it 👍🏼
We could settle this long standing dilemma once and for all :-)

@kartikaykaushik14
Copy link
Contributor Author

@nicolas-raoul Can we please close this issue since we resolved it in #5182?

@nicolas-raoul
Copy link
Member

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants