Media needs refactoring to remove code that has been rendered useless

[kbhardwaj123]

Summary:

After analysing the media section i came across the following things which can be removed:

• The MediaDetailSpacer class has been rendered useless, it was previously used in the fragment_media_detail.xml file but after some recent changes it is not required.

• The updateTheDarkness method inside MediaDetailFragment was used when we had a partially transparent media detail fragment so that when the user pulls it up the Alpha of the image was changed to make the details readable but now since the design has been completely overhauled i think we should remove this.

This is what the updateTheDarkness method does:
Before Scroll

After Scroll

Would you like to work on the issue?
Yes :)

[macgills]

I'd say definitely remove MediaDetailSpacer

The fade is sort of nice(?) but I don't see a reason for it to be there. I'd wait for more people to weigh in on that.

[kbhardwaj123]

Tagging @neslihanturan for review on this aspect

[misaochan]

I feel that both can be removed. The fade is not worth the extra complexity now IMO.

[neslihanturan]

I agree about removing both, simplicity is better.

[neslihanturan]

I agree about removing both, simplicity is better.

[kbhardwaj123]

since most of us are in favour of removing both i will create a PR for the same