Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profiles #3389

Closed
nicolas-raoul opened this issue Feb 8, 2020 · 11 comments · Fixed by #4678
Closed

User profiles #3389

nicolas-raoul opened this issue Feb 8, 2020 · 11 comments · Fixed by #4678

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 8, 2020

Currently, tapping a user's name (when seeing a picture's details) does nothing.
It would be great if that could open an activity that shows:

  • This user's level and statistics (reuse the current Achievements activity? Or even transform the Achievements activity to just show one's own profile activity?)
  • A "view in browser" button that shows a link to this user's web page, for instance https://commons.wikimedia.org/wiki/User:Syced
  • A gallery of this user's pictures, just like in the home activity.

If users are conscious that they have a profile page and that other people can look at it, maybe they will be encouraged to contribute better/more?
If we do it right, this could even give ideas to the website version of Commons.

@animeshk08
Copy link
Contributor

I would like to work on this issue. @nicolas-raoul .
I think we can show the user's webpage on clicking the username. It would encourage them to upload more pictures and also get more details of the images they have already uploaded

@nicolas-raoul
Copy link
Member Author

@animeshk08 Thanks for getting involved! Are you sure you satisfy this condition, though? :-)

Issues labeled "enhancement" will usually only be assigned to contributors with >5 previous contributions to this repo.
https://github.com/commons-app/apps-android-commons/wiki/Volunteers-welcome%21#developers

@misaochan
Copy link
Member

I love this idea! @nicolas-raoul Do you know how it would tie in with the Leaderboard that is due to be implemented in GSoC? It seems to me like some of the logic could be reused.

@misaochan
Copy link
Member

Also, I wonder if it is possible to pull barnstars from the user's page? If it is, this could tie in nicely with #2428 , so we could award a barnstar to winners, and it would be viewable in their profile page.

@neslihanturan
Copy link
Collaborator

neslihanturan commented Apr 26, 2021

Hi all, here I my suggested mockups for this feature.
1- Where to reach a user profile from:
howToGetThere2

2- What will happen when we tap on user name from one of these 6 access points:
userProfile2

Looking forward to hear your feedbacks :)

@nicolas-raoul
Copy link
Member Author

Should it be possible to reach a user from the leaderboard? I wonder who is this Vojtech who outranked me ;-)

Will you add a "View user page" in the three-dots menu, similar to "View file page" and "View item page"?

@neslihanturan
Copy link
Collaborator

Thanks for pointing out important points @nicolas-raoul , I edited the designs accordingly in my previous comment. How did you find the updated versions?

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Apr 26, 2021

About the 4th screenshot of section 1: I agree that tapping "Fae" should open Fae's profile.

About the 5th screenshot of section 1: I don't think a search loop widget is necessary here, as it is already present in Explore.

About the 6th screenshot of section 1: I think that "View user page" would be more relevant in section 2 (achievements/leaderboard/contributions screen).

@misaochan
Copy link
Member

Hi @neslihanturan , thanks for the mockups! :)

1- Where to reach a user profile from:

I think this is a very ambitious plan and perhaps it may be better to stick to something a bit more basic for the initial prototype. ;) Increasing the access points increases the potential for issues and the need for debugging, besides adding UI complexity. I would vote for only item 1, 4, and 6, and not implement the rest. Especially with item 2, it is too easy to mis-tap when you want to actually view the image instead.

2- What will happen when we tap on user name from one of these 6 access points:

Looks good to me!

@ashishkumar468
Copy link
Collaborator

ashishkumar468 commented Apr 30, 2021

To summarise the expected behavior:
Clicks on the author names in places mentioned in Screenshots 1,4 & 6 would open the Profile-Section for that particular user where we will be showing the Achievements, Leaderboard and the ContributionsList of that user. Question: Will we be supporting clicks on contributions? @misaochan

ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue May 1, 2021
Changes
- Profile Activity, AchievementsFragment, ContributionsFragment & LeaderboardFragment  accept username instead of using the default account
- Added RemoteDataSource for contrubutions which do not persist contributions
- On Clicks on AuthorNames in 1. MediaDetails, Menu-Options in MediaDetails & Leaderboard list takes to the profile of that user with the corresponding Achievements, Leaderboard and ContributionsList
@misaochan
Copy link
Member

Question: Will we be supporting clicks on contributions? @misaochan

I don't think we need to have this in the initial rollout of this feature. It can be an enhancement for the future. :)

ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 18, 2021
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 18, 2021
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 18, 2021
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 18, 2021
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 18, 2021
neslihanturan pushed a commit that referenced this issue Oct 25, 2021
* Fixes #3389 - Show  User profiles

* Don't show dummy achievements data - show data only when loaded
@misaochan misaochan added this to the v3.2.0 beta milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment