Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SignupActivity to an Activity from a WebView #1298

Closed
diddypod opened this issue Mar 13, 2018 · 11 comments
Closed

Change SignupActivity to an Activity from a WebView #1298

diddypod opened this issue Mar 13, 2018 · 11 comments
Assignees

Comments

@diddypod
Copy link

Summary:

SignupActivity is currently a WebView, which is inconsistent with the res of the application and allows users to browse MediaWiki in the WebView without logging in

Expected

SignupActivity should be an Android Activity

Observed behavior:

It is a WebView.

Device and Android version:

Xiaomi (Wingtech) Redmi 2 Prime
Xiaomi Redmi Note 4

Commons app version:

2.6.7-debug

@diddypod
Copy link
Author

diddypod commented Mar 13, 2018

This can be easily implemented using JavaScript injection in a WebView. I'd like to take this up.

This has been discussed in part in issue #1151.

@madhurgupta10
Copy link
Collaborator

Please allow me to work on this :)

@misaochan
Copy link
Member

@diddypod Sorry we didn't get back to you about this. Are you still interested in working on it?

@diddypod
Copy link
Author

diddypod commented Mar 26, 2018

Yes, please. May I take it up, @misaochan?

@nicolas-raoul
Copy link
Member

@diddypod Yes feel free :-)

@diddypod
Copy link
Author

diddypod commented Mar 26, 2018

JavaScript injection is a rather hacky implementation. I'll try to make it somewhat better by using the MediaWiki APIs for account creation, as outlined at MediaWiki API help - action=createaccount (create) and API:Account creation

@diddypod
Copy link
Author

diddypod commented Apr 1, 2018

Hello

Really sorry for the inactivity and the lack of updates, I've been having evaluations in college. I've been tinkering away in my free time, though, and while the bulk of the process is working, I'm having a bit of trouble retrieving and displaying the captcha via APIs. Any help or insights?

@misaochan
Copy link
Member

Hi @diddypod , no worries. :) I am afraid that I can't offer any help with the captcha because that is exactly where I got stuck the last time I tried to implement this. :/ Perhaps someone else can chime in?

@diddypod
Copy link
Author

Hello

Again, sorry for the delay. I've been working on this for the past couple of days and I have found these tools

API:Account Creation needs a CAPTCHA to work, but I haven't been able to use the Extension using the APIs.

The alternative is to create an Android layout and use JavaScript injection as I said earlier which seems hacky and pointless, since it does not improve or simplify functionality, instead adding more complexity to the current webview implementation.

I'd like to stop working on this issue, and take up some other issues.

@misaochan
Copy link
Member

@diddypod Thanks for the effort that you put into this. I am inclined to agree with you - as mentioned, I also tried to implement this a couple of years ago and ran into the same roadblocks. An additional concern is futureproofing - if we use the WebView, any changes that WMF makes to the signup process will automatically be incorporated, whereas with our own implementation we would need to keep on top of things ourselves.

Please feel free to work on other issues. Would you like me to close this?

@diddypod
Copy link
Author

diddypod commented May 26, 2018

Thank you @misaochan. Please close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants