Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show complete text of welcome notification #1224

Closed
ayushin78 opened this issue Feb 27, 2018 · 8 comments
Closed

Show complete text of welcome notification #1224

ayushin78 opened this issue Feb 27, 2018 · 8 comments

Comments

@ayushin78
Copy link
Contributor

Summary:
Welcome Notification doesn't redirect the user to any link. As a user, I would like to know the complete information displayed in the notification. So, Either it should redirect the user to an external link containing the full information or it should show the complete text of the notification.

Steps to reproduce:

  1. After Login, click on Notifications.
  2. Check the welcome notification.

Device and Android version:
Samsung A8
Android 6.0 Marshmallow

Commons app version:
2.6.7

Screen-shots:
2

How will I proceed on this issue
Since the API itself doesn't provide any link for welcome notifications. Removing the maxLines limit of title can be a quick fix. @maskaravivek please let me know if this approach is okay, will open the PR accordingly.
Thanks. :)

@maskaravivek
Copy link
Member

Am not sure how the notifications would look if the message is too long. Instead of removing the maxLines limit we can probably just increase it.
Moreover:

  • It would be great if we could reduce the padding and size of the image. That would give us some more space for the notification text.

@Jatin0312
Copy link
Contributor

Can't we include a button in notification to completely see the notification, so whenever a user clicks on that notification button complete text will be displayed something like see more, see fewer buttons in LinkedIn, Facebook.
Example:
bug

@maskaravivek
Copy link
Member

The see more option actually makes sense and it would be great if we could implement that.

@Jatin0312
Copy link
Contributor

I would like to work on this issue

@maskaravivek
Copy link
Member

Sure, please feel free to pick this up. :)

@Jatin0312
Copy link
Contributor

@maskaravivek I have created a fix. Please review it, I will create a pull request accordingly. Thanks :)
Screenshot showing what changed.
solved3

@maskaravivek
Copy link
Member

@Jatin0312 I couldn't find the PR for this. Can you attach a link for it.

@Jatin0312
Copy link
Contributor

Ya sure, I will send a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants