-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show complete text of welcome notification #1224
Comments
Am not sure how the notifications would look if the message is too long. Instead of removing the
|
The see more option actually makes sense and it would be great if we could implement that. |
I would like to work on this issue |
Sure, please feel free to pick this up. :) |
@maskaravivek I have created a fix. Please review it, I will create a pull request accordingly. Thanks :) |
@Jatin0312 I couldn't find the PR for this. Can you attach a link for it. |
Ya sure, I will send a PR soon. |
Fix for issue #1224 showing complete notification on click
Summary:
Welcome Notification doesn't redirect the user to any link. As a user, I would like to know the complete information displayed in the notification. So, Either it should redirect the user to an external link containing the full information or it should show the complete text of the notification.
Steps to reproduce:
Device and Android version:
Samsung A8
Android 6.0 Marshmallow
Commons app version:
2.6.7
Screen-shots:
How will I proceed on this issue
Since the API itself doesn't provide any link for welcome notifications. Removing the maxLines limit of title can be a quick fix. @maskaravivek please let me know if this approach is okay, will open the PR accordingly.
Thanks. :)
The text was updated successfully, but these errors were encountered: