Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gesture for navigation drawer #1151

Open
97balakrishnan opened this issue Feb 14, 2018 · 5 comments
Open

Adding gesture for navigation drawer #1151

97balakrishnan opened this issue Feb 14, 2018 · 5 comments

Comments

@97balakrishnan
Copy link
Contributor

Summary:

swipe gesture to open navigation drawer on create account screen has not been added

Device and Android version:

Stock version of android 6.0

Commons app version:

2.6.7

@diddypod
Copy link

diddypod commented Feb 15, 2018

The Sign Up page seems to be a webView, so it's probably beyond the scope of the app to implement swipe gestures there.
However, should we allow users to navigate through the site without logging in? If yes, we should put that option on the Log In screen.

@97balakrishnan
Copy link
Contributor Author

Yeah. I think that the entire create account page can be made into an android activity to ensure uniformity in the app.

@97balakrishnan
Copy link
Contributor Author

Can i start working on it?

@misaochan
Copy link
Member

I'm okay with an Android activity being used to handle sign ups instead of the webview. I doubt that it will be an easy task, but anyone who is interested in working on it is certainly welcome to do so. :)

I am on the fence re: the nav drawer being accessible in the signup activity. Currently the app is built around the assumption that the user HAS to be logged in. Allowing non-logged in users to navigate the app would require a refactor of several other components AFAIK, and needs more discussion.

@97balakrishnan
Copy link
Contributor Author

97balakrishnan commented Feb 15, 2018

okay. I will try doing this after discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants