-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gesture for navigation drawer #1151
Comments
The Sign Up page seems to be a webView, so it's probably beyond the scope of the app to implement swipe gestures there. |
Yeah. I think that the entire create account page can be made into an android activity to ensure uniformity in the app. |
Can i start working on it? |
I'm okay with an Android activity being used to handle sign ups instead of the webview. I doubt that it will be an easy task, but anyone who is interested in working on it is certainly welcome to do so. :) I am on the fence re: the nav drawer being accessible in the signup activity. Currently the app is built around the assumption that the user HAS to be logged in. Allowing non-logged in users to navigate the app would require a refactor of several other components AFAIK, and needs more discussion. |
okay. I will try doing this after discussions. |
Summary:
swipe gesture to open navigation drawer on create account screen has not been added
Device and Android version:
Stock version of android 6.0
Commons app version:
2.6.7
The text was updated successfully, but these errors were encountered: