Filter out irrelevant categories #1029
Comments
|
We can skip all "in the XXXXs" categories except 2000s and 2010s, as people should not use the app to upload very old pictures. |
|
Hi, I'll start working on this issue! |
|
Hi there, I have forked achalshant's branch and added my code here: https://github.com/janani-sridhar/apps-android-commons/blob/master/app/src/main/java/fr/free/nrw/commons/category/PrefixUpdater.java I'm not sure how to create a pull request for this fix, considering that I was working off of achalshant's branch. Hope to hear some feedback and advice soon! |
|
Please merge master into your branch, then rebase. Thanks! 🙂
…On Jan 6, 2018 12:31, "janani-sridhar" ***@***.***> wrote:
Hi there,
I have forked achalshant's branch and added my code here:
https://github.com/janani-sridhar/apps-android-commons/
blob/master/app/src/main/java/fr/free/nrw/commons/category/
PrefixUpdater.java
I'm not sure how to create a pull request for this fix, considering that I
was working off of achalshant's branch. Hope to hear some feedback and
advice soon!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1029 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBs6NWS0WmxCNxh896FYda67YzqXUks5tHvcugaJpZM4ROFDj>
.
|
|
This issue seems to be open! can I take this up? |
|
@janani-sridhar Could you please let you know if you are still working on this? We would like to give the issue to @junkiattan if you aren't. :) Thanks! |
|
@misaochan @nicolas-raoul |
|
@junkiattan OK! |
Filter out irrelevant categories (to filter out before 2000s when year is in format XXXX) #1029
|
@junkiattan handled some parts of this issue recently, however it requires more effort. So, I wont close this now. |
|
Currently we filtered out before 2000s as it has written as XXXX format. But can we describe what do we exactly want to filter out? |
|
I can further extend the part of the code I touched to exclude the YY.MM.DD formats that do not pass a certain year. However the years are expressed in 2 digits, hence it is a little tricky to set a cut off year (e.g. should 99 now be defined as old?) |
|
I would personally consider 99 to be "old" in the context of smartphones. But indeed the 2 digit years are a problem. I guess we could go with allowing '1x' and '0x' through and filter out the others? |
|
@misaochan |
|
@junkiattan We've got a good 2 years before that happens, so IMO not necessary, we can make that change when it happens. ;) |
|
@junkiattan Please do not filter based on the "YY.MM.DD" format. I guess you got confused because of my "Image class" screenshot, which is unrelated. I should probably have created separate issues. Only filter out categories that end with the string " in the XYZ0s" (XYZ being an integer between 1 and 200). |
|
I have already done this in my first PR for this issue. Can this be closed now then? If so then I will close my second PR |
|
Yes @junkiattan maybe you can close your second PR and I can close the issue. Thanks for quick responses. |
We are in the 2020s now. So, adjust fix for issue 1029 to include 2020s too.
We are in the 2020s now. So, adjust fix for issue 1029 to include 2020s too.
This was an experiment that has been abandoned, but the 300 categories remain: https://commons.wikimedia.org/wiki/Commons:Image_classification_system
Tip for newcomers: achalshant@3681176
The text was updated successfully, but these errors were encountered: