Convert the LoginClient to kotlin (#5479)

* Convert the result classes to kotlin

* Convert response and callback to kotlin

* Cleanup code-quality warnings before converting

* Converted the LoginClient to kotlin

* Updated the UserExtendedInfoClientTest to be kotlin, and live in the correct spot

app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java

@@ -31,11 +31,10 @@
 import fr.free.nrw.commons.databinding.ActivityLoginBinding;
 import fr.free.nrw.commons.utils.ActivityUtils;
 import java.util.Locale;
-import org.wikipedia.AppAdapter;
 import org.wikipedia.dataclient.ServiceFactory;
 import org.wikipedia.dataclient.WikiSite;
 import org.wikipedia.dataclient.mwapi.MwQueryResponse;
-import fr.free.nrw.commons.auth.login.LoginClient.LoginCallback;
+import fr.free.nrw.commons.auth.login.LoginCallback;
 
 import javax.inject.Inject;
 import javax.inject.Named;

app/src/main/java/fr/free/nrw/commons/auth/csrf/CsrfTokenClient.kt

@@ -8,8 +8,8 @@ import org.wikipedia.dataclient.SharedPreferenceCookieManager
 import org.wikipedia.dataclient.WikiSite
 import org.wikipedia.dataclient.mwapi.MwQueryResponse
 import fr.free.nrw.commons.auth.login.LoginClient
-import fr.free.nrw.commons.auth.login.LoginClient.LoginCallback
-import fr.free.nrw.commons.auth.login.LoginClient.LoginFailedException
+import fr.free.nrw.commons.auth.login.LoginCallback
+import fr.free.nrw.commons.auth.login.LoginFailedException
 import fr.free.nrw.commons.auth.login.LoginResult
 import retrofit2.Call
 import retrofit2.Response
@@ -129,7 +129,7 @@ class CsrfTokenClient(
     ) = LoginClient()
         .request(csrfWikiSite, username, password, object : LoginCallback {
         override fun success(loginResult: LoginResult) {
-            if (loginResult.pass()) {
+            if (loginResult.pass) {
                 sessionManager.updateAccount(loginResult)
                 retryCallback()
             } else {

app/src/main/java/fr/free/nrw/commons/auth/login/LoginCallback.kt

@@ -0,0 +1,8 @@
+package fr.free.nrw.commons.auth.login
+
+interface LoginCallback {
+    fun success(loginResult: LoginResult)
+    fun twoFactorPrompt(caught: Throwable, token: String?)
+    fun passwordResetPrompt(token: String?)
+    fun error(caught: Throwable)
+}