Skip to content

fix(dist): import module#40

Merged
gregswindle merged 2 commits intomasterfrom
38-defect-import-failure
May 21, 2019
Merged

fix(dist): import module#40
gregswindle merged 2 commits intomasterfrom
38-defect-import-failure

Conversation

@gregswindle
Copy link
Contributor

@gregswindle gregswindle commented May 21, 2019

git Pull Request Pull Request (PR)

Update outdated rollup-plugins.

The dev-dependency rollup-plugin-node-resolve
introduced a breaking change. Once the mainFields
property had values, rollup.js worked again.

Also set package.json#files to "dist", which
ensures the distribution if much smaller, e.g.,

> npm pack

npm notice 
npm notice 📦  archetypes-rules@1.1.0
npm notice === Tarball Contents === 
npm notice 10.4kB package.json            
npm notice 5.6kB  CHANGELOG.md            
npm notice 1.1kB  LICENSE                 
npm notice 28.5kB README.md               
npm notice 21.7kB dist/archetypes-rules.js
npm notice === Tarball Details === 
npm notice name:          archetypes-rules                        
npm notice version:       1.1.0                                   
npm notice filename:      archetypes-rules-1.1.0.tgz              
npm notice package size:  15.9 kB                                 
npm notice unpacked size: 67.4 kB                                 
npm notice shasum:        3bfa34ba536ae0da9ad269be437b816666c8db33
npm notice integrity:     sha512-uBVSNTpQopypQ[...]AEgNGpHoZIBUQ==
npm notice total files:   5                                       
npm notice 
archetypes-rules-1.1.0.tgz

Introduce two new npm-scripts to make pre-release
testing easier:

  1. bundle:clean - removes ./dist/ and *.tgz
  2. postbundle - calls npm pack

Associated issue(s)

Closes #35
Closes #36
Closes #37
Closes #38
Closes #39


  • 1. The acceptance criteria for all associated issues have been
    completed, tested, and validated.
  • 2. The README either reflects my changes or does not require updates.
  • 3. The CONTRIBUTING document either reflects my changes or does not
    require updates.

View the "Code Review Cheat-sheet"...

Rule 1: Review all Code before Releasing it

Do the code reviews before deployment.

Why:

Your team will end up, on average, spending 7% more of its time on building
new features compared with those who do after, and 10% more than those who
don’t do code reviews at all.

Rule 2: All developers review code

Make sure all your developers get to review code.

Why:

This will improve the feeling of empowerment, facilitate knowledge transfer,
and improve developer satisfaction and productivity.

Rule 3: Four-to-Eight (4-8) Hours per Developers per Week

The optimal amount of time to spend on code reviews is between 0.5 to 1 day per
week per developer.

Rule 4: Don't Release Code that Fails Reviews

Make code reviews blocking, that is, don’t deploy before they have been carried
out.

Rule 5: More Rigor, Better Quality and Velocity

Be strict and thorough when reviewing code.

Why:

Your code quality and velocity will thank you.


Code quality summary

Measure Scores
Quality gate Sonar Alert Status Metrics
Duplications Sonar Duplicated Lines Density Metrics
Maintainability Sonar Code Smells Metrics
Sonar Sqale Rating Metrics
Sonar Sqale Index Metrics
Sonar Ncloc Metrics
Reliability Sonar Reliability Rating Metrics
Sonar Bugs Metrics
Security Sonar Security Rating Metrics
Sonar Vulnerabilities Metrics
Test coverage Sonar Coverage Metrics

Code quality, vulnerability, and standards compliance tools

Code Style Linters Test frameworks
JavaScript Style Guide ESLint Jest BDD
Standard JS user guide link-external ESlint user guide link-external Jest user guide link-external

How to format, lint, and test your changes

Open a Terminal, go to the root directory for archetypes-rules, and run:

$ npm test

info Completed tasks are not required to open a PR, and may
be addressed while the PR is open.

alert All tasks must be completed and verified
before a PR may be merged into master, however.

How to test a release

The Pre-release test instructions include step-by-step guidelines for bundling, packing, and testing this module as it would be released on NPM.


Update outdated rollup-plugins.

The  introduced a breaking
change. Once the  property had values,
rollup.js worked again.

Also set package.json#files to "dist", which
ensures the distribution if much smaller.

Introduce two new npm-scripts to make pre-release
testing easier:

1. bundle:clean - removes ./dist/ and *.tgz
2. postbundle - calls npm pack

#38
@gregswindle gregswindle self-assigned this May 21, 2019
@gregswindle gregswindle added type: build Changes to product build. type: chore Changes that don't modify source or test files. type: docs Add, edit, or delete instructional material. type: fix Defect repairs. ⇧ Bumps the PATCH semver. labels May 21, 2019
@gregswindle gregswindle added this to the Extend StringVariable milestone May 21, 2019
Add missing ENV VARS:

- # Codacy

CODACY_PROJECT_TOKEN=

# CodeClimate

CC_TEST_REPORTER_ID=

#38
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 01dd9dc and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@gregswindle gregswindle added the type: dependency Update or pin a third-party library. ⇧ Bump the PATCH semver. label May 21, 2019
@gregswindle gregswindle merged commit c22a8ef into master May 21, 2019
@gregswindle gregswindle deleted the 38-defect-import-failure branch May 21, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: build Changes to product build. type: chore Changes that don't modify source or test files. type: dependency Update or pin a third-party library. ⇧ Bump the PATCH semver. type: docs Add, edit, or delete instructional material. type: fix Defect repairs. ⇧ Bumps the PATCH semver.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defect: v1.1.0 package will not load

1 participant