Merged
Conversation
Update outdated rollup-plugins. The introduced a breaking change. Once the property had values, rollup.js worked again. Also set package.json#files to "dist", which ensures the distribution if much smaller. Introduce two new npm-scripts to make pre-release testing easier: 1. bundle:clean - removes ./dist/ and *.tgz 2. postbundle - calls npm pack #38
Add missing ENV VARS: - # Codacy CODACY_PROJECT_TOKEN= # CodeClimate CC_TEST_REPORTER_ID= #38
|
Code Climate has analyzed commit 01dd9dc and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update outdated rollup-plugins.
The dev-dependency
rollup-plugin-node-resolveintroduced a breaking change. Once the
mainFieldsproperty had values, rollup.js worked again.
Also set package.json#files to "dist", which
ensures the distribution if much smaller, e.g.,
> npm pack npm notice npm notice 📦 archetypes-rules@1.1.0 npm notice === Tarball Contents === npm notice 10.4kB package.json npm notice 5.6kB CHANGELOG.md npm notice 1.1kB LICENSE npm notice 28.5kB README.md npm notice 21.7kB dist/archetypes-rules.js npm notice === Tarball Details === npm notice name: archetypes-rules npm notice version: 1.1.0 npm notice filename: archetypes-rules-1.1.0.tgz npm notice package size: 15.9 kB npm notice unpacked size: 67.4 kB npm notice shasum: 3bfa34ba536ae0da9ad269be437b816666c8db33 npm notice integrity: sha512-uBVSNTpQopypQ[...]AEgNGpHoZIBUQ== npm notice total files: 5 npm notice archetypes-rules-1.1.0.tgzIntroduce two new npm-scripts to make pre-release
testing easier:
Associated issue(s)
Closes #35
Closes #36
Closes #37
Closes #38
Closes #39
completed, tested, and validated.
require updates.
View the "Code Review Cheat-sheet"...
Rule 1: Review all Code before Releasing it
Do the code reviews before deployment.
Why:
Rule 2: All developers review code
Make sure all your developers get to review code.
Why:
Rule 3: Four-to-Eight (4-8) Hours per Developers per Week
The optimal amount of time to spend on code reviews is between 0.5 to 1 day per
week per developer.
Rule 4: Don't Release Code that Fails Reviews
Make code reviews blocking, that is, don’t deploy before they have been carried
out.
Rule 5: More Rigor, Better Quality and Velocity
Be strict and thorough when reviewing code.
Why:
Code quality summary
Code quality, vulnerability, and standards compliance tools
How to format, lint, and test your changes
Open a Terminal, go to the root directory for archetypes-rules, and run:
$ npm testHow to test a release
The Pre-release test instructions include step-by-step guidelines for bundling, packing, and testing this module as it would be released on NPM.