feat(variable): extend string-variable#34
Merged
gregswindle merged 2 commits intomasterfrom May 20, 2019
Merged
Conversation
Add operator methods: 1. endsWith 2. hasMaxLength 3. hasMinLength 4. isEmpty 5. isNotEmpty 6. isOneOf 7. includes 8. matches 9. startsWith Validate arguments to be of an expected type, when applicable. #33
Run sonar-scan locally to produce a report. #33
|
Code Climate has analyzed commit f58b844 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add operator methods to
StringVariable:endsWithhasMaxLengthhasMinLengthisEmptyisNotEmptyisOneOfincludesmatchesstartsWithValidate arguments to be of an expected type, when
applicable.
Associated issue(s)
Closes #33
completed, tested, and validated.
require updates.
View the "Code Review Cheat-sheet"...
Rule 1: Review all Code before Releasing it
Do the code reviews before deployment.
Why:
Rule 2: All developers review code
Make sure all your developers get to review code.
Why:
Rule 3: Four-to-Eight (4-8) Hours per Developers per Week
The optimal amount of time to spend on code reviews is between 0.5 to 1 day per
week per developer.
Rule 4: Don't Release Code that Fails Reviews
Make code reviews blocking, that is, don’t deploy before they have been carried
out.
Rule 5: More Rigor, Better Quality and Velocity
Be strict and thorough when reviewing code.
Why:
Code quality summary
Code quality, vulnerability, and standards compliance tools
How to format, lint, and test your changes
Open a Terminal, go to the root directory for archetypes-rules, and run:
$ npm testHow to test a release
The Pre-release test instructions include step-by-step guidelines for bundling, packing, and testing this module as it would be released on NPM.