how to specify network access with example #381
Conversation
| ``` | ||
| url: https://www.commonwl.org/v1.2/ | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I think we also need to document what happens when networkAccess: false. I believe this flag is a suggestion, and it may or may not block the network access (it does not in cwltool, yet, common-workflow-language/cwltool#1733).
There was a problem hiding this comment.
The flag doesn't block the network access; I ran the above code with networkAcess: false and it still downloaded the file.
There was a problem hiding this comment.
Correct. It's planned work for cwltool. But would be useful to document the expected behavior in the spec and maybe in cwltool as well.
There was a problem hiding this comment.
So can I say that when the networkAccess value is false, the code still runs, but we do not expect it to?
There was a problem hiding this comment.
I think we must say what happens in both cases. We can probably use or adapt the text from the specification, where it explains it's an indicative flag, what implementations/users can expect, and the meaning of true or false for the flag: https://www.commonwl.org/v1.2/CommandLineTool.html#NetworkAccess
src/faq.md
Outdated
| If `networkAccess` is `true`the tool must be able to make | ||
| outgoing connections to network resources. | ||
| If `networkAccess` is `false` or not specified, tools must not | ||
| assume network access, except for localhost(the loopback device). |
There was a problem hiding this comment.
localhost(the loopback device).
Missing space, and maybe format it as localhost (the loopback device).
fixes #249