Skip to content

Conversation

kinow
Copy link
Member

@kinow kinow commented Mar 10, 2022

A pull request for issues found during the deployment of 1.4.2 to the existing environment.

Description

Placeholder for all issues found.

Motivation and Context

Deployment issues.

How Has This Been Tested?

Unfortunately, while deploying the code 😅

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kinow
Copy link
Member Author

kinow commented Mar 10, 2022

Thanks to Ward for the patience going through the new deployment instructions, and for spotting the pg_hba.conf typo.

@mr-c
Copy link
Member

mr-c commented Mar 11, 2022

👍👍👍

@kinow kinow self-assigned this Mar 31, 2022
@kinow kinow marked this pull request as ready for review March 31, 2022 06:41
@kinow kinow force-pushed the fixes-deployment branch from d5ad6c8 to e60d314 Compare March 31, 2022 06:51
@kinow
Copy link
Member Author

kinow commented Mar 31, 2022

In the issue #395 & PR #396, one workflow would not render after migrating the data from MongoDB to PostgreSQL.

After troubleshooting it, I realized it was due to a change in recent versions of Thymeleaf (template used in SpringBoot). It disallows static methods accessed in the template. I've rebased this branch, and added a change to send the result of the static method from the controller, already processed, to the template.

Tested on the workflow that was not rendering and it fixed the problem 🎉 🥳 N.B. this does not block the MongoDB migration, since once the template is fixed, the workflow graph will be rendered just fine.

@mr-c
Copy link
Member

mr-c commented Mar 31, 2022

👍 Feel free to self merge

@kinow kinow merged commit 06e8361 into main Mar 31, 2022
@kinow kinow deleted the fixes-deployment branch March 31, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants