Skip to content

Conversation

stain
Copy link
Member

@stain stain commented Nov 21, 2019

Description

Provide InputStream and Path based methods for returning from GraphService, instead of the oldie File using temporary files.

Motivation and Context

The current implementation has excessive use of temporary files.

This patch will improve #239 by avoiding it making temporary files just to call the methods or return images over HTTP.

How Has This Been Tested?

CWLServiceTest and GraphVizServiceTest have been updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2019

This pull request introduces 2 alerts when merging f36ef42 into 3a5c2d0 - view on LGTM.com

new alerts:

  • 2 for Spurious Javadoc @param tags

@stain stain merged commit 8df24dd into master Nov 21, 2019
@stain stain deleted the stream-cwl-graph branch November 21, 2019 14:17
This was referenced Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant