Support packed workflows in permalinks #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might also be some UI tweaks in there.. sorry! |
Also smaller permalink (should not need <code> anymore)
.. which shows representations as text/uri-list and permalinks per format
Added getIdentifier() that gives the old #foo variant - useful for matching with the RDF output and as graph name in the RDF In preparation for #176 to support permalinks for packed workflows. getPermaLink(Format) uses enum instead of strings (which might not match a known format)
In preparation for #167 so we can build raw URIs (Really the datamodel is upside-down to support that at the moment) Should probably return a Stream rather than a List for effiency (later we'll just pick the first one that has the commit). also.. is it possible to return the RetrievedFrom object instead of Workflow?
to support #167
(but not by ?format=)
This fixes #167 by looking up any matching commit ID
Fixes #176 by adding a new ?part= to the permalinks (It does not change the current %23 escaping in the UI, but that could also be considered. The UI parts are fixed to enable the permalinks also for packed workflows)
.. so that ?format=json works in browsers Fixes #166.
This is part of #176
stain
force-pushed
the
permalinks-packed
branch
from
3767fad to
1f30577
Compare
stain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176 by adding a new ?part= to the permalinks
(It does not change the current %23 escaping in the UI, but that could
also be considered. The UI parts are fixed to enable the permalinks also
for packed workflows)
Support ?format=json in redirects.
Fixes #166.
Support ?format=raw for any git file
Fixes #167.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: