-
-
Notifications
You must be signed in to change notification settings - Fork 232
Coverage reporting #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage reporting #691
Conversation
Can you also look at the Makefile which has some related targets? It is good to enable local feedback too. Thanks! |
What is the functionality that is needed in the Makefile? |
Yes, which might already exist but should be documented in our non-existent developer guide 😋 |
So this is the result I have right now:
as a by-product xml and html reports are also generated. |
Also makes setuptools install cov-pytest, right now coverage is only generated by unit tests
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=========================================
Coverage ? 62.37%
=========================================
Files ? 26
Lines ? 4274
Branches ? 1147
=========================================
Hits ? 2666
Misses ? 1325
Partials ? 283 Continue to review full report at Codecov.
|
To avoid failure states
Makefile
Outdated
coverage.html: htmlcov/index.html | ||
|
||
htmlcov/index.html: .coverage | ||
python-coverage html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep the HTML report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In retrospect, we can also keep the xml report
this is awesome! |
This adds coverage reporting and uploading to both coveralls and codecov, any of which can be easily disabled.
A common-workflow-language admin should give access to codecov or coveralls to enable uploads to them.
This PR supersedes #526