Skip to content

Fix duplicated logging, only initialize defaultStreamHandler once. #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cwltool/argparser.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,14 @@

from typing import (Any, AnyStr, Dict, List, Sequence, Text, Union, cast)

from . import loghandler
from schema_salad.ref_resolver import file_uri
from .process import (Process, shortname)
from .resolver import ga4gh_tool_registries
from .software_requirements import (SOFTWARE_REQUIREMENTS_ENABLED)

_logger = logging.getLogger("cwltool")

defaultStreamHandler = logging.StreamHandler()
_logger.addHandler(defaultStreamHandler)
_logger.setLevel(logging.INFO)


def arg_parser(): # type: () -> argparse.ArgumentParser
parser = argparse.ArgumentParser(description='Reference executor for Common Workflow Language')
parser.add_argument("--basedir", type=Text)
Expand Down
17 changes: 6 additions & 11 deletions cwltool/executors.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,15 @@

from typing import Dict, Text, Any, Tuple, Set, List

from cwltool.builder import Builder
from cwltool.errors import WorkflowException
from cwltool.mutation import MutationManager
from cwltool.job import JobBase
from cwltool.process import relocateOutputs, cleanIntermediate, Process

from .builder import Builder
from .errors import WorkflowException
from .mutation import MutationManager
from .job import JobBase
from .process import relocateOutputs, cleanIntermediate, Process
from . import loghandler

_logger = logging.getLogger("cwltool")

defaultStreamHandler = logging.StreamHandler()
_logger.addHandler(defaultStreamHandler)
_logger.setLevel(logging.INFO)


class JobExecutor(object):
__metaclass__ = ABCMeta

Expand Down
6 changes: 6 additions & 0 deletions cwltool/loghandler.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import logging

_logger = logging.getLogger("cwltool")
defaultStreamHandler = logging.StreamHandler()
_logger.addHandler(defaultStreamHandler)
_logger.setLevel(logging.INFO)
6 changes: 1 addition & 5 deletions cwltool/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from .load_tool import (FetcherConstructorType, resolve_tool_uri,
fetch_document, make_tool, validate_document, jobloaderctx,
resolve_overrides, load_overrides)
from .loghandler import defaultStreamHandler
from .mutation import MutationManager
from .pack import pack
from .pathmapper import (adjustDirObjs, trim_listing, visit_class)
Expand All @@ -43,11 +44,6 @@

_logger = logging.getLogger("cwltool")

defaultStreamHandler = logging.StreamHandler()
_logger.addHandler(defaultStreamHandler)
_logger.setLevel(logging.INFO)


def single_job_executor(t, # type: Process
job_order_object, # type: Dict[Text, Any]
**kwargs # type: Any
Expand Down