Separate requirements and hints when caching #2102
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue with some of the conformance tests with caching as mentioned on the Toil side: DataBiosphere/toil#5187 (comment)
iwd-container-entryname1.cwl
has the DockerRequirement under the requirements key: https://github.com/common-workflow-language/cwl-v1.2/blob/707ebcd2173889604459c5f4ffb55173c508abb3/tests/iwd/iwd-container-entryname1.cwl#L14But
iwd-container-entryname3.cwl
has the DockerRequirement under the hints key: https://github.com/common-workflow-language/cwl-v1.2/blob/707ebcd2173889604459c5f4ffb55173c508abb3/tests/iwd/iwd-container-entryname3.cwl#L14When hashing for caching, hints and requirements are considered the same, so a previous run of
iwd-container-entryname1.cwl
will result in a cache hit foriwd-container-entryname3.cwl
, even though the two tasks should have different behaviors/results