Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate requirements and hints when caching #2102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stxue1
Copy link
Contributor

@stxue1 stxue1 commented Feb 19, 2025

Resolves an issue with some of the conformance tests with caching as mentioned on the Toil side: DataBiosphere/toil#5187 (comment)

iwd-container-entryname1.cwl has the DockerRequirement under the requirements key: https://github.com/common-workflow-language/cwl-v1.2/blob/707ebcd2173889604459c5f4ffb55173c508abb3/tests/iwd/iwd-container-entryname1.cwl#L14

But iwd-container-entryname3.cwl has the DockerRequirement under the hints key: https://github.com/common-workflow-language/cwl-v1.2/blob/707ebcd2173889604459c5f4ffb55173c508abb3/tests/iwd/iwd-container-entryname3.cwl#L14

When hashing for caching, hints and requirements are considered the same, so a previous run of iwd-container-entryname1.cwl will result in a cache hit for iwd-container-entryname3.cwl, even though the two tasks should have different behaviors/results

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.76%. Comparing base (1b56338) to head (8e020fb).

Files with missing lines Patch % Lines
cwltool/command_line_tool.py 50.00% 3 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (1b56338) and HEAD (8e020fb). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (1b56338) HEAD (8e020fb)
17 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2102       +/-   ##
===========================================
- Coverage   84.77%   70.76%   -14.02%     
===========================================
  Files          46       46               
  Lines        8359     8362        +3     
  Branches     1960     1961        +1     
===========================================
- Hits         7086     5917     -1169     
- Misses        805     1838     +1033     
- Partials      468      607      +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant