Skip to content

MyPy stubs rename #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 1, 2022
Merged

MyPy stubs rename #1699

merged 8 commits into from
Aug 1, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Aug 1, 2022

using the name typeshed was causing incomplete checking of the type stubs themselves

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1699 (59db016) into main (1c2cbfc) will increase coverage by 0.02%.
The diff coverage is 72.97%.

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
+ Coverage   66.86%   66.89%   +0.02%     
==========================================
  Files          93       93              
  Lines       16706    16712       +6     
  Branches     4430     4430              
==========================================
+ Hits        11171    11180       +9     
+ Misses       4390     4387       -3     
  Partials     1145     1145              
Impacted Files Coverage Δ
cwltool/cwlrdf.py 29.06% <27.27%> (+0.83%) ⬆️
cwltool/provenance_profile.py 73.23% <88.88%> (ø)
cwltool/cwlviewer.py 98.91% <100.00%> (+0.01%) ⬆️
cwltool/software_requirements.py 67.94% <100.00%> (+0.41%) ⬆️
cwltool/cwltool/software_requirements.py 25.64% <0.00%> (-0.34%) ⬇️
cwltool/cwltool/provenance_profile.py 11.01% <0.00%> (ø)
cwltool/cwltool/job.py 62.25% <0.00%> (+0.79%) ⬆️
cwltool/cwltool/cwlviewer.py 22.82% <0.00%> (+0.84%) ⬆️
cwltool/cwltool/cwlrdf.py 18.60% <0.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging a3a57a8 into 1c2cbfc - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging 48428a4 into 1c2cbfc - view on LGTM.com

new alerts:

  • 1 for Unused import

@mr-c mr-c force-pushed the mypy_stubs_rename branch from 48428a4 to 59db016 Compare August 1, 2022 16:52
@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging 59db016 into 1c2cbfc - view on LGTM.com

new alerts:

  • 1 for Unused import

@mr-c mr-c enabled auto-merge (squash) August 1, 2022 18:02
@mr-c mr-c disabled auto-merge August 1, 2022 18:02
@mr-c mr-c merged commit 9eeccee into main Aug 1, 2022
@mr-c mr-c deleted the mypy_stubs_rename branch August 1, 2022 18:02
GlassOfWhiskey pushed a commit that referenced this pull request Sep 15, 2022
* rename our local type stubs dir & fix types

As per python/mypy#13155 (comment)

* upgrade minimum ruamel.yaml versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant