Skip to content

fixing Nonetype not iterable error #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2017
Merged

fixing Nonetype not iterable error #23

merged 1 commit into from
Jul 16, 2017

Conversation

kapilkd13
Copy link
Contributor

fixing this error https://ci.commonwl.org/job/cwltool-pr-conformance-multiver/543/version=v1.0/console . Error occures when we iterate over a empty list of args.testargs.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this fix?

@kapilkd13
Copy link
Contributor Author

The code which caused this problem is inside main method and I can't seem to find a good way to test it, as once we invoke main method we would need a tool and workflow to successful execution. Also this particular issue was caused because we were reading a empty list, so i don't think a test is necessary for this. But since this issue arrived while all checks passed, so a test to run a particular workflow is needed.
I am thinking we can fetch a particular conformance test, install a previously released tagged version of cwltool(not current version, so that its behaviour does not change with time) and test that conformance test. Is this a good idea. If yes, I would work on it after windows compatibility is complete. For now I think we can merge this PR as current version is broken and will affect all cwltool builds. What do you say

@mr-c mr-c mentioned this pull request Jul 16, 2017
@mr-c mr-c merged commit ef911a8 into master Jul 16, 2017
@mr-c
Copy link
Member

mr-c commented Jul 16, 2017

@kapilkd13 Sure! See #24

@mr-c mr-c deleted the fixNonetype branch July 16, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants