Skip to content

Add strict schema #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2022
Merged

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented May 21, 2022

This request introduces a strict schema for cwltest as a preparation of #110.
Here is a difference of cwltest-schema and strict schema.

  • id field is limited to string,
  • label field is removed, and
  • tags field is mandatory

It enable us to migrate to a new schema and enable us not to introduce a regression that uses current schema with integer id field.
Note that it is not to enforce a new schema because it breaks existing systems that depend on the current schema of cwltest.

It is also important to add deprecation and migration messages in cwltest but it is out of scope of this request.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #138 (398e2d9) into main (b65f9b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   60.04%   60.04%           
=======================================
  Files           2        2           
  Lines         453      453           
  Branches      133      133           
=======================================
  Hits          272      272           
  Misses        139      139           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65f9b7...398e2d9. Read the comment docs.

@tom-tan
Copy link
Member Author

tom-tan commented May 28, 2022

ping!

@mr-c mr-c merged commit 9672fa5 into common-workflow-language:main May 30, 2022
@mr-c
Copy link
Member

mr-c commented May 30, 2022

Thanks!

@tom-tan tom-tan deleted the add-strict-schema branch May 30, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants